Paths

Table of Contentst

Differential D14359

Herald support for changing task status
ClosedPublic
Actions

Authored by jasonfsmitty on Oct 28 2015, 6:36 PM.

Tags

None

Referenced Files

	F13084848: D14359.diff
	Wed, Apr 24, 11:27 PM

	Unknown Object (File)
	Fri, Apr 19, 3:51 PM

	Unknown Object (File)
	Sun, Apr 14, 4:27 PM

	Unknown Object (File)
	Thu, Apr 11, 7:55 AM

	Unknown Object (File)
	Wed, Apr 10, 11:35 AM

	Unknown Object (File)
	Fri, Apr 5, 9:22 AM

	Unknown Object (File)
	Fri, Apr 5, 9:22 AM

	Unknown Object (File)
	Fri, Apr 5, 3:21 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions

Commits

Restricted Diffusion Commit
rPa77bf877d4f1: Herald support for changing task status

Summary

Ref T7848. This patch is incomplete and has the following issues:

Multiple statuses can be entered on the edit rule page (only the first one is used).
Statuses are not rendered correctly when re-editing a rule.

Test Plan

Applied to our local phab instance and verified it works with our task workflow.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonfsmitty updated this revision to Diff 34669.Oct 28 2015, 6:36 PM

jasonfsmitty retitled this revision from to T7848: herald support for changing task status.

jasonfsmitty updated this object.

jasonfsmitty edited the test plan for this revision. (Show Details)

jasonfsmitty added a subscriber: jsmith.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 28 2015, 6:36 PM

Herald added a subscriber: epriestley. · View Herald Transcript

jasonfsmitty added a task: T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.Oct 28 2015, 6:36 PM

jasonfsmitty mentioned this in T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.Oct 28 2015, 6:49 PM

revi added a subscriber: revi.Oct 29 2015, 11:54 AM

joshuaspence retitled this revision from T7848: herald support for changing task status to Herald support for changing task status.Nov 13 2015, 9:35 AM

joshuaspence updated this object.

joshuaspence edited edge metadata.

joshuaspence added a subscriber: joshuaspence.

Some minor inlines, I'll just clean these up in the pull.

src/applications/maniphest/herald/ManiphestTaskStatusHeraldAction.php
27	Prefer `head()` to `reset()` in this codebase.
29	This should be DO_STANDARD_EMPTY (empty rule), not DO_STANDARD_NO_EFFECT (valid rule with no effect considering current state).
55	Use ManiphestTaskStatus::getTaskStatusName() to render a name.
56	Debugging/testing code.

This revision is now accepted and ready to land.Dec 5 2015, 6:50 PM

Closed by commit rPa77bf877d4f1: Herald support for changing task status (authored by Jason Smith <jsmith@rajant.com>, committed by epriestley). · Explain WhyDec 5 2015, 6:55 PM

This revision was automatically updated to reflect the committed changes.

Statuses are not rendered correctly when re-editing a rule.

Sorry, totally skipped over this. Following up in T7848.

epriestley mentioned this in D14682: Improve rendering of tokenizer tokens in Herald when editing rules.Dec 5 2015, 7:12 PM

epriestley mentioned this in rP82be07315cbf: Improve rendering of tokenizer tokens in Herald when editing rules.Dec 5 2015, 7:20 PM

epriestley mentioned this in T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed.Dec 16 2015, 6:27 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

maniphest/

herald/

ManiphestTaskStatusHeraldAction.php

87 lines

Diff 35508

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/herald/ManiphestTaskStatusHeraldAction.php

Loading...