Differential D14680
Fix confusing ordering of similar actions in transaction groups Authored by epriestley on Dec 5 2015, 6:08 PM. Tags None Referenced Files
Subscribers Tokens
Details
Fixes T7250. Currently, if a display group of transactions (multiple transactions by the same author in a short period of time with no intervening comments) has several transactions of similar strength (e.g., several status change transactions) we can end up displaying them in reverse chronological order, which is confusing. Instead, make sure transactions of the same type/strength are always in logical order.
Diff Detail
Event Timeline
Comment Actions Maybe this would be easier as msort($group, array('getActionStrength', 'getId')) (with appropriate modifications to msort()) Comment Actions I think those modifications would need to involve usort(), which has huge overhead. In most cases I add a getSortKey() and build a composite scalar, but I think getActionStrength() returns a float and I don't have a clever way to combine a float and an int into a single sortable scalar offhand that I trust. Something like %016.8f%012d probably works I don't know how many places the float needs offhand. Comment Actions (We could also just make getActionStrength() return integers instead, which is probably more consistent and simpler.) | ||||||||||||||||||||||||||||||||||||