Page MenuHomePhabricator
Differential D14630

Update Subscriptions for handleRequest
ClosedPublic
Actions

Authored by chad on Dec 2 2015, 4:07 AM.
Tags
None
Referenced Files
F15483438: D14630.id35406.diff
Wed, Apr 9, 12:15 PM
F15474787: D14630.id35396.diff
Sun, Apr 6, 12:39 PM
F15471944: D14630.diff
Sat, Apr 5, 9:51 AM
F15471054: D14630.id35407.diff
Sat, Apr 5, 3:02 AM
F15468613: D14630.id35396.diff
Fri, Apr 4, 2:58 AM
F15468612: D14630.id35406.diff
Fri, Apr 4, 2:58 AM
F15443106: D14630.id35407.diff
Thu, Mar 27, 2:24 AM
F15439930: D14630.diff
Wed, Mar 26, 10:20 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rP1b61af126fe8: Update Subscriptions for handleRequest
Summary

Modernizes Subscriptions

Test Plan

Subscribe/Unsubscribe... anything else?

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9217
Build 10912: Run Core Tests
Build 10911: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35396.Dec 2 2015, 4:07 AM
chad retitled this revision from to Update Subscriptions for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 2 2015, 4:07 AM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Dec 2 2015, 4:09 AM
chad updated this revision to Diff 35406.Dec 2 2015, 3:57 PM
  • use request instead of this
epriestley accepted this revision.Dec 2 2015, 3:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2015, 3:57 PM
Closed by commit rP1b61af126fe8: Update Subscriptions for handleRequest (authored by chad, committed by chad). · Explain WhyDec 2 2015, 3:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35406

View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

Loading...
View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php

Loading...
View Options

src/applications/subscriptions/controller/PhabricatorSubscriptionsTransactionController.php

Loading...
Phabricator · Built by Phacility