Paths

Table of Contentst

Differential D14615

Include `n_LEXICAL_VARIABLE_LIST` in parentheses spacing linter rule
Needs RevisionPublic
Actions

Authored by joshuaspence on Nov 30 2015, 9:01 PM.

Tags

None

Referenced Files

	F14027398: D14615.diff
	Fri, Nov 8, 7:04 AM

	F13997189: D14615.diff
	Thu, Oct 24, 2:55 AM

	F13994101: D14615.diff
	Wed, Oct 23, 3:48 AM

	Unknown Object (File)
	Aug 30 2024, 9:15 AM

	Unknown Object (File)
	Aug 26 2024, 9:34 PM

	Unknown Object (File)
	Aug 26 2024, 5:55 AM

	Unknown Object (File)
	Aug 26 2024, 5:38 AM

	Unknown Object (File)
	Aug 25 2024, 6:44 PM

View All 88 Files

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

Includes n_LEXICAL_VARIABLE_LIST in the parentheses spacing linter rule such that a linter message is raised for use ( $x). Depends on D14614.

Test Plan

Added test cases.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9166
Build 10828: Run Core Tests
Build 10827: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	97 ms	ArcanistParenthesesSpacingXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	14 ms	ArcanistParenthesesSpacingXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	3,208 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	106 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	28 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 288 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35356.Nov 30 2015, 9:01 PM

joshuaspence retitled this revision from to Include `n_LEXICAL_VARIABLE_LIST` in parentheses spacing linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D14614: Improve parsing of lexical variable lists.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 9:01 PM

Herald added a subscriber: Korvin. · View Herald Transcript

joshuaspence mentioned this in D14614: Improve parsing of lexical variable lists.Nov 30 2015, 9:17 PM

joshuaspence updated this object.Nov 30 2015, 9:24 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

That lint output looks whacky to me? ($y ) should be ($y) (no trailing space)? Am I just misunderstanding?

The test case itself seems to fail.

This revision now requires changes to proceed.Dec 22 2015, 1:37 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistParenthesesSpacingXHPASTLinterRule.php

3 lines

ArcanistVariableReferenceSpacingXHPASTLinterRule.php

4 lines

__tests__/

parentheses-spacing/

closure.lint-test

12 lines

Diff 35356

src/lint/linter/xhpast/rules/ArcanistParenthesesSpacingXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistVariableReferenceSpacingXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/tests/parentheses-spacing/closure.lint-test

Loading...