Page MenuHomePhabricator

Improve parsing of lexical variable lists
Needs ReviewPublic

Authored by joshuaspence on Nov 30 2015, 8:54 PM.
Tags
None
Referenced Files
F13221341: D14614.diff
Sun, May 19, 2:35 AM
F13205152: D14614.diff
Wed, May 15, 1:29 AM
Unknown Object (File)
Mon, May 6, 4:09 PM
Unknown Object (File)
Mon, Apr 29, 10:22 AM
Unknown Object (File)
Mar 29 2024, 4:01 AM
Unknown Object (File)
Mar 10 2024, 5:38 AM
Unknown Object (File)
Feb 8 2024, 10:05 PM
Unknown Object (File)
Jan 31 2024, 3:41 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Adds a new n_USE_LEXICAL_VARIABLES node. This will make more sense after my next diff (see D14615).

I'm not 100% set on the name of this node, so feel free to suggest alternatives. I personally find the use of use in PHP somewhat confusing because it is a rather overloaded construct:

For completeness, the following relationships are meant to be similar:

  • n_ARRAY_LITERAL and n_ARRAY_VALUE_LIST
  • n_LIST and n_ASSIGNMENT_LIST
  • n_USE_LEXICAL_VARIABLES and n_LEXICAL_VARIABLE_LIST
  • n_USE_LIST and n_USE
Test Plan

Added unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9164
Build 10825: Run Core Tests
Build 10824: arc lint + arc unit