Page MenuHomePhabricator

Improve parsing of lexical variable lists
Needs ReviewPublic

Authored by joshuaspence on Nov 30 2015, 8:54 PM.
Tags
None
Referenced Files
F14020839: D14614.diff
Wed, Nov 6, 3:02 AM
F13961675: D14614.id35354.diff
Tue, Oct 15, 5:53 AM
Unknown Object (File)
Sep 9 2024, 1:51 PM
Unknown Object (File)
Aug 10 2024, 11:25 PM
Unknown Object (File)
Aug 7 2024, 2:01 AM
Unknown Object (File)
Jul 15 2024, 11:06 PM
Unknown Object (File)
Jul 7 2024, 2:36 AM
Unknown Object (File)
Jul 5 2024, 10:31 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Adds a new n_USE_LEXICAL_VARIABLES node. This will make more sense after my next diff (see D14615).

I'm not 100% set on the name of this node, so feel free to suggest alternatives. I personally find the use of use in PHP somewhat confusing because it is a rather overloaded construct:

For completeness, the following relationships are meant to be similar:

  • n_ARRAY_LITERAL and n_ARRAY_VALUE_LIST
  • n_LIST and n_ASSIGNMENT_LIST
  • n_USE_LEXICAL_VARIABLES and n_LEXICAL_VARIABLE_LIST
  • n_USE_LIST and n_USE
Test Plan

Added unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9164
Build 10825: Run Core Tests
Build 10824: arc lint + arc unit