Page MenuHomePhabricator
Differential D14610

Versions Panel: Show extensions, dates
ClosedPublic
Actions

Authored by avivey on Nov 30 2015, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 12:03 AM
Unknown Object (File)
Wed, Jan 29, 9:14 PM
Unknown Object (File)
Wed, Jan 29, 9:13 PM
Unknown Object (File)
Wed, Jan 29, 9:13 PM
Unknown Object (File)
Wed, Jan 29, 9:13 PM
Unknown Object (File)
Tue, Jan 28, 3:29 PM
Unknown Object (File)
Sat, Jan 25, 12:57 AM
Unknown Object (File)
Fri, Jan 24, 10:09 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Like" token, awarded by joshuaspence.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9788: config/versions page - also show dates of commits
Commits
Restricted Diffusion Commit
rP2fba7e66e720: Versions Panel: Show extensions, dates
Summary

ref T9788

Test Plan

pasted_file (222×588 px, 32 KB)

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9155
Build 10809: Run Core Tests
Build 10808: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 35344.Nov 30 2015, 7:14 PM
avivey retitled this revision from to Versions Panel: Show extensions, dates.
avivey edited the test plan for this revision. (Show Details)
avivey updated this object.
avivey added a task: T9788: config/versions page - also show dates of commits.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 7:14 PM
Herald added a subscriber: epriestley. · View Herald Transcript
avivey edited the test plan for this revision. (Show Details)Nov 30 2015, 7:15 PM
avivey edited edge metadata.
epriestley accepted this revision.Nov 30 2015, 7:17 PM
epriestley added a reviewer: epriestley.

Maybe just get rid of all the special casing for Phabricator/Arcanist/libphutil? I think it's fine if it just says "phabricator" instead of "Phabricator Version".

(Then maybe sort the results by library name?)

This revision is now accepted and ready to land.Nov 30 2015, 7:17 PM
joshuaspence awarded a token.Nov 30 2015, 7:17 PM
avivey added a comment.Nov 30 2015, 7:21 PM

I like that the core libs are always in the same order and on top (Muscle memory). But removing the $title would probably simplify the code.

avivey added inline comments.Nov 30 2015, 7:25 PM
src/applications/config/module/PhabricatorConfigVersionsModule.php
72

I think this actually doesn't do anything?

avivey updated this revision to Diff 35345.Nov 30 2015, 7:27 PM
avivey edited edge metadata.

That simplified it quite a bit...

Herald added a subscriber: Korvin. · View Herald TranscriptNov 30 2015, 7:27 PM
Closed by commit rP2fba7e66e720: Versions Panel: Show extensions, dates (authored by avivey, committed by avivey). · Explain WhyNov 30 2015, 10:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
module/
46 lines

Diff 35345

View Options

src/applications/config/module/PhabricatorConfigVersionsModule.php

Loading...
Phabricator · Built by Phacility