Page MenuHomePhabricator
Differential D14570

Fix an issue with parsing `n_USE_LIST`
ClosedPublic
Actions

Authored by joshuaspence on Nov 25 2015, 9:30 AM.
Tags
None
Referenced Files
F18798871: D14570.diff
Fri, Oct 17, 9:31 AM
F18670976: D14570.diff
Thu, Sep 25, 2:20 AM
F18629925: D14570.id35247.diff
Sep 16 2025, 10:17 AM
Unknown Object (File)
May 25 2025, 6:37 AM
Unknown Object (File)
Apr 18 2025, 1:01 PM
Unknown Object (File)
Apr 17 2025, 7:22 PM
Unknown Object (File)
Apr 17 2025, 2:38 AM
Unknown Object (File)
Apr 6 2025, 12:50 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUd26ec9f3357e: (stable) Promote 2015 Week 48
rPHUf0881b37049c: Fix an issue with parsing `n_USE_LIST`
Summary

Fix a minor issue with parsing n_USE_LIST nodes caused by D14518.

Test Plan
xhpast-before.png (361×217 px, 13 KB)
xhpast.after.png (352×205 px, 13 KB)
BeforeAfter

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9056
Build 10655: Run Core Tests
Build 10654: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35247.Nov 25 2015, 9:30 AM
joshuaspence retitled this revision from to Fix an issue with parsing `n_USE_LIST`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 25 2015, 9:30 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 25 2015, 2:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2015, 2:57 PM
Closed by commit rPHUf0881b37049c: Fix an issue with parsing `n_USE_LIST` (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 25 2015, 7:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
110 lines
58 lines
bin/
2 lines
support/
xhpast/
8 lines
22 lines
2 lines

Diff 35247

View Options

src/parser/xhpast/__tests__/data/php-syntax.php.test

Loading...
View Options

src/parser/xhpast/__tests__/data/use.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility