Page MenuHomePhabricator

Improve parsing of `use` statements
ClosedPublic

Authored by joshuaspence on Nov 19 2015, 8:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 11:25 AM
Unknown Object (File)
Fri, Nov 15, 9:03 PM
Unknown Object (File)
Fri, Nov 8, 8:43 PM
Unknown Object (File)
Fri, Nov 8, 7:56 PM
Unknown Object (File)
Fri, Nov 8, 7:08 PM
Unknown Object (File)
Mon, Oct 28, 6:45 PM
Unknown Object (File)
Thu, Oct 24, 10:52 PM
Unknown Object (File)
Oct 22 2024, 9:25 AM
Subscribers

Details

Summary

The way that we parse use statements at the moment is a bit odd. For example, consider the following example:

<?php

use A\B\C;
use X\Y\Z;

This is currently parsed as:

xhpast-before.png (336×182 px, 8 KB)

After this change, it is instead parsed as:

xhpast-after.png (279×166 px, 7 KB)

Test Plan

Added a test case.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Improve parsing on `use` statements.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 19 2015, 4:34 PM
joshuaspence retitled this revision from Improve parsing on `use` statements to Improve parsing of `use` statements.Nov 19 2015, 7:47 PM
joshuaspence edited edge metadata.
This revision was automatically updated to reflect the committed changes.