Page MenuHomePhabricator

Remove backticks from console-formatted strings
AbandonedPublic

Authored by joshuaspence on Nov 24 2015, 8:26 PM.
Tags
None
Referenced Files
F14029562: D14569.id35242.diff
Fri, Nov 8, 8:48 PM
F14026617: D14569.id35238.diff
Fri, Nov 8, 1:49 AM
F14005409: D14569.id35240.diff
Sun, Oct 27, 12:30 PM
F13985616: D14569.id35239.diff
Sun, Oct 20, 9:48 PM
F13967723: D14569.id35242.diff
Wed, Oct 16, 3:32 PM
F13956169: D14569.id35238.diff
Mon, Oct 14, 4:31 AM
Unknown Object (File)
Sep 20 2024, 4:20 AM
Unknown Object (File)
Sep 20 2024, 2:27 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Remve ` from console-formatted strings because we can't really render them properlyn anyway (most console have a monospaced font by default).

Test Plan

Added unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9050
Build 10645: Run Core Tests
Build 10644: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Remove backticks from console-formatted strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Really what we should do here is ensure that text within backticks is formatted literally. This would solve the issue described in D14563#164583. I'm not really sure how to go about this though.

joshuaspence edited edge metadata.

Seems to work now

I think it's fine/desirable to emit this literal text onto the console:

Run `ls -l` to see files in the current directory.

Specifically, even when not marked up, this is more clear than:

Run ls -l to see files in the current directory.

...since it points out the ends of the token and which parts are and are not components of the command.

I think there's a different fix for D14563#164583, let me look at that.