Page MenuHomePhabricator

Remove backticks from console-formatted strings
AbandonedPublic

Authored by joshuaspence on Nov 24 2015, 8:26 PM.
Tags
None
Referenced Files
F15492152: D14569.diff
Sat, Apr 12, 11:41 AM
F15480667: D14569.id35239.diff
Tue, Apr 8, 3:35 PM
F15468365: D14569.id35242.diff
Thu, Apr 3, 11:49 PM
F15465261: D14569.id35239.diff
Wed, Apr 2, 4:35 PM
F15464675: D14569.id35242.diff
Wed, Apr 2, 12:14 PM
F15463733: D14569.id35241.diff
Wed, Apr 2, 2:36 AM
F15462615: D14569.id35238.diff
Tue, Apr 1, 4:22 PM
F15462401: D14569.id35240.diff
Tue, Apr 1, 2:53 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Remve ` from console-formatted strings because we can't really render them properlyn anyway (most console have a monospaced font by default).

Test Plan

Added unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9051
Build 10647: Run Core Tests
Build 10646: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Remove backticks from console-formatted strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Really what we should do here is ensure that text within backticks is formatted literally. This would solve the issue described in D14563#164583. I'm not really sure how to go about this though.

joshuaspence edited edge metadata.

Seems to work now

I think it's fine/desirable to emit this literal text onto the console:

Run `ls -l` to see files in the current directory.

Specifically, even when not marked up, this is more clear than:

Run ls -l to see files in the current directory.

...since it points out the ends of the token and which parts are and are not components of the command.

I think there's a different fix for D14563#164583, let me look at that.