Paths

Table of Contentst

Differential D14526

Add a linter rule to ensure that `namespace` is the first statement in a file
ClosedPublic
Actions

Authored by joshuaspence on Nov 19 2015, 10:13 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCeeaa176cfc5a: Add a linter rule to ensure that `namespace` is the first statement in a file

Summary

If a namespace is used within a PHP script, it must be the first statement.

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9071
Build 10678: Run Core Tests
Build 10677: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	643 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	57 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	25 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	33 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 286 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35138.Nov 19 2015, 10:13 PM

joshuaspence retitled this revision from to Add a linter rule to ensure that `namespace` is the first statement in a file.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2015, 10:13 PM

Herald added a subscriber: Korvin. · View Herald Transcript

<?php

1;

namespace X {
  class C { }
  echo 2;
}

Look at me, I'm PHP!

This revision is now accepted and ready to land.Nov 19 2015, 10:18 PM

Almost 100 linter rules, woot!

Add a test case for an edge case

Closed by commit rARCeeaa176cfc5a: Add a linter rule to ensure that `namespace` is the first statement in a file (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 25 2015, 8:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

rules/

ArcanistNamespaceFirstStatementXHPASTLinterRule.php

36 lines

__tests__/

ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php

11 lines

namespace-first-statement/

class-before-namespace.lint-test

5 lines

incorrect.lint-test

16 lines

multiple-namespaces.lint-test

7 lines

no-namespace.lint-test

3 lines

Diff 35261

View Options

src/__phutil_library_map__.php

View Options

src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/class-before-namespace.lint-test

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/incorrect.lint-test

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/multiple-namespaces.lint-test

View Options

src/lint/linter/xhpast/rules/tests/namespace-first-statement/no-namespace.lint-test

Add a linter rule to ensure that `namespace` is the first statement in a fileClosedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 35261

src/__phutil_library_map__.php

src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/class-before-namespace.lint-test

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/incorrect.lint-test

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/multiple-namespaces.lint-test

src/lint/linter/xhpast/rules/__tests__/namespace-first-statement/no-namespace.lint-test

Add a linter rule to ensure that `namespace` is the first statement in a file
ClosedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/ArcanistNamespaceFirstStatementXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/namespace-first-statement/class-before-namespace.lint-test

src/lint/linter/xhpast/rules/tests/namespace-first-statement/incorrect.lint-test

src/lint/linter/xhpast/rules/tests/namespace-first-statement/multiple-namespaces.lint-test

src/lint/linter/xhpast/rules/tests/namespace-first-statement/no-namespace.lint-test