Paths

Table of Contentst

Improve test data format for XHPAST unit tests
12167cf6fb23
Actions

Description

Improve test data format for XHPAST unit tests

Summary: Instead of having the input data and expected output stored in separate files, combine all data into a single file format similar to the *.lint-test format.

Test Plan: Ran unit tests.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14500

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Nov 18 2015, 8:35 PM

Reviewer

Blessed Reviewers

Differential Revision

D14500: Improve test data format for XHPAST unit tests

Parents

rPHU67f26422b91a: Use setters instead of public properties

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8909
Build 10436: Run Core Tests

Event Timeline

joshuaspence committed rPHU12167cf6fb23: Improve test data format for XHPAST unit tests (authored by joshuaspence).Nov 18 2015, 8:14 PM

Harbormaster completed building B8909: rPHU12167cf6fb23: Improve test data format for XHPAST unit tests.Nov 18 2015, 8:36 PM

Changes (46)

Path

Size

src/

parser/

xhpast/

__tests__/

PHPASTParserTestCase.php

data/

base-fail-parse.php.expect

base-fail-parse.php.test

base-fail-syntax.php.test

base-pass.php.expect

base-pass.php.test

namespace.php.expect

	namespace.php.test
	namespace.php.expect

php-access-on-instanciation-invalid.test

php-access-on-instanciation.expect

	php-access-on-instanciation.test
	php-access-on-instanciation.expect

php-array-dereference-2.expect

	php-array-dereference-2.test
	php-array-dereference-2.expect

php-array-dereference-3.expect

	php-array-dereference-3.test
	php-array-dereference-3.expect

php-array-dereference.expect

	php-array-dereference.test
	php-array-dereference.expect

php-binary-literal.php.expect

	php-binary-literal.php.test
	php-binary-literal.php.expect

php-callable-typehint.php.expect

	php-callable-typehint.php.test
	php-callable-typehint.php.expect

php-class-expr.php.test

php-comments.php.expect

	php-comments.php.test
	php-comments.php.expect

php-empty-heredoc.php.expect

	php-empty-heredoc.php.test
	php-empty-heredoc.php.expect

php-finally.php.expect

	php-finally.php.test
	php-finally.php.expect

php-foreach-list.php.test

php-heredoc-terminal.php.expect

	php-heredoc-terminal.php.test
	php-heredoc-terminal.php.expect

php-literal-index.php.expect

	php-literal-index.php.test
	php-literal-index.php.expect

php-literals.php.expect

	php-literals.php.test
	php-literals.php.expect

php-nested-quotes.test

php-short-array.php.expect

	php-short-array.php.test
	php-short-array.php.expect

php-syntax.php.expect

	php-syntax.php.test
	php-syntax.php.expect

php-tags.php.expect

	php-tags.php.test
	php-tags.php.expect

php-traits.php.expect

	php-traits.php.test
	php-traits.php.expect

php-yield.php.expect

	php-yield.php.test
	php-yield.php.expect

rPHU12167cf6fb23

View Options

src/parser/xhpast/tests/PHPASTParserTestCase.php

View Options

src/parser/xhpast/tests/data/base-fail-parse.php.expect

View Options

src/parser/xhpast/tests/data/base-fail-parse.php.test

View Options

src/parser/xhpast/tests/data/base-fail-syntax.php.test

View Options

src/parser/xhpast/tests/data/base-pass.php.expect

View Options

src/parser/xhpast/tests/data/base-pass.php.test

View Options

src/parser/xhpast/tests/data/namespace.php.expect

View Options

src/parser/xhpast/tests/data/namespace.php.test

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation-invalid.test

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-2.expect

View Options

src/parser/xhpast/tests/data/php-array-dereference-2.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-3.expect

View Options

src/parser/xhpast/tests/data/php-array-dereference-3.test

View Options

src/parser/xhpast/tests/data/php-array-dereference.expect

View Options

src/parser/xhpast/tests/data/php-array-dereference.test

View Options

src/parser/xhpast/tests/data/php-binary-literal.php.expect

View Options

src/parser/xhpast/tests/data/php-binary-literal.php.test

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.test

View Options

src/parser/xhpast/tests/data/php-class-expr.php.test

View Options

src/parser/xhpast/tests/data/php-comments.php.expect

View Options

src/parser/xhpast/tests/data/php-comments.php.test

View Options

src/parser/xhpast/tests/data/php-empty-heredoc.php.expect

View Options

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

View Options

src/parser/xhpast/tests/data/php-finally.php.expect

View Options

src/parser/xhpast/tests/data/php-finally.php.test

View Options

src/parser/xhpast/tests/data/php-foreach-list.php.test

View Options

src/parser/xhpast/tests/data/php-heredoc-terminal.php.expect

View Options

src/parser/xhpast/tests/data/php-heredoc-terminal.php.test

View Options

src/parser/xhpast/tests/data/php-literal-index.php.expect

View Options

src/parser/xhpast/tests/data/php-literal-index.php.test

View Options

src/parser/xhpast/tests/data/php-literals.php.expect

View Options

src/parser/xhpast/tests/data/php-literals.php.test

View Options

src/parser/xhpast/tests/data/php-nested-quotes.test

View Options

src/parser/xhpast/tests/data/php-short-array.php.expect

View Options

src/parser/xhpast/tests/data/php-short-array.php.test

View Options

src/parser/xhpast/tests/data/php-syntax.php.expect

View Options

src/parser/xhpast/tests/data/php-syntax.php.test

View Options

src/parser/xhpast/tests/data/php-tags.php.expect

View Options

src/parser/xhpast/tests/data/php-tags.php.test

View Options

src/parser/xhpast/tests/data/php-traits.php.expect

View Options

src/parser/xhpast/tests/data/php-traits.php.test

View Options

src/parser/xhpast/tests/data/php-yield.php.expect

View Options

src/parser/xhpast/tests/data/php-yield.php.test

Improve test data format for XHPAST unit tests12167cf6fb23Actions

Description

Details

Event Timeline

Changes (46)

rPHU12167cf6fb23

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

src/parser/xhpast/__tests__/data/base-fail-parse.php.expect

src/parser/xhpast/__tests__/data/base-fail-parse.php.test

src/parser/xhpast/__tests__/data/base-fail-syntax.php.test

src/parser/xhpast/__tests__/data/base-pass.php.expect

src/parser/xhpast/__tests__/data/base-pass.php.test

src/parser/xhpast/__tests__/data/namespace.php.expect

src/parser/xhpast/__tests__/data/namespace.php.test

src/parser/xhpast/__tests__/data/php-access-on-instanciation-invalid.test

src/parser/xhpast/__tests__/data/php-access-on-instanciation.expect

src/parser/xhpast/__tests__/data/php-access-on-instanciation.test

src/parser/xhpast/__tests__/data/php-array-dereference-2.expect

src/parser/xhpast/__tests__/data/php-array-dereference-2.test

src/parser/xhpast/__tests__/data/php-array-dereference-3.expect

src/parser/xhpast/__tests__/data/php-array-dereference-3.test

src/parser/xhpast/__tests__/data/php-array-dereference.expect

src/parser/xhpast/__tests__/data/php-array-dereference.test

src/parser/xhpast/__tests__/data/php-binary-literal.php.expect

src/parser/xhpast/__tests__/data/php-binary-literal.php.test

src/parser/xhpast/__tests__/data/php-callable-typehint.php.expect

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

src/parser/xhpast/__tests__/data/php-class-expr.php.test

src/parser/xhpast/__tests__/data/php-comments.php.expect

src/parser/xhpast/__tests__/data/php-comments.php.test

src/parser/xhpast/__tests__/data/php-empty-heredoc.php.expect

src/parser/xhpast/__tests__/data/php-empty-heredoc.php.test

src/parser/xhpast/__tests__/data/php-finally.php.expect

src/parser/xhpast/__tests__/data/php-finally.php.test

src/parser/xhpast/__tests__/data/php-foreach-list.php.test

src/parser/xhpast/__tests__/data/php-heredoc-terminal.php.expect

src/parser/xhpast/__tests__/data/php-heredoc-terminal.php.test

src/parser/xhpast/__tests__/data/php-literal-index.php.expect

src/parser/xhpast/__tests__/data/php-literal-index.php.test

src/parser/xhpast/__tests__/data/php-literals.php.expect

src/parser/xhpast/__tests__/data/php-literals.php.test

src/parser/xhpast/__tests__/data/php-nested-quotes.test

src/parser/xhpast/__tests__/data/php-short-array.php.expect

src/parser/xhpast/__tests__/data/php-short-array.php.test

src/parser/xhpast/__tests__/data/php-syntax.php.expect

src/parser/xhpast/__tests__/data/php-syntax.php.test

src/parser/xhpast/__tests__/data/php-tags.php.expect

src/parser/xhpast/__tests__/data/php-tags.php.test

src/parser/xhpast/__tests__/data/php-traits.php.expect

src/parser/xhpast/__tests__/data/php-traits.php.test

src/parser/xhpast/__tests__/data/php-yield.php.expect

src/parser/xhpast/__tests__/data/php-yield.php.test

Improve test data format for XHPAST unit tests
12167cf6fb23
Actions

src/parser/xhpast/tests/PHPASTParserTestCase.php

src/parser/xhpast/tests/data/base-fail-parse.php.expect

src/parser/xhpast/tests/data/base-fail-parse.php.test

src/parser/xhpast/tests/data/base-fail-syntax.php.test

src/parser/xhpast/tests/data/base-pass.php.expect

src/parser/xhpast/tests/data/base-pass.php.test

src/parser/xhpast/tests/data/namespace.php.expect

src/parser/xhpast/tests/data/namespace.php.test

src/parser/xhpast/tests/data/php-access-on-instanciation-invalid.test

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

src/parser/xhpast/tests/data/php-access-on-instanciation.test

src/parser/xhpast/tests/data/php-array-dereference-2.expect

src/parser/xhpast/tests/data/php-array-dereference-2.test

src/parser/xhpast/tests/data/php-array-dereference-3.expect

src/parser/xhpast/tests/data/php-array-dereference-3.test

src/parser/xhpast/tests/data/php-array-dereference.expect

src/parser/xhpast/tests/data/php-array-dereference.test

src/parser/xhpast/tests/data/php-binary-literal.php.expect

src/parser/xhpast/tests/data/php-binary-literal.php.test

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

src/parser/xhpast/tests/data/php-callable-typehint.php.test

src/parser/xhpast/tests/data/php-class-expr.php.test

src/parser/xhpast/tests/data/php-comments.php.expect

src/parser/xhpast/tests/data/php-comments.php.test

src/parser/xhpast/tests/data/php-empty-heredoc.php.expect

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

src/parser/xhpast/tests/data/php-finally.php.expect

src/parser/xhpast/tests/data/php-finally.php.test

src/parser/xhpast/tests/data/php-foreach-list.php.test

src/parser/xhpast/tests/data/php-heredoc-terminal.php.expect

src/parser/xhpast/tests/data/php-heredoc-terminal.php.test

src/parser/xhpast/tests/data/php-literal-index.php.expect

src/parser/xhpast/tests/data/php-literal-index.php.test

src/parser/xhpast/tests/data/php-literals.php.expect

src/parser/xhpast/tests/data/php-literals.php.test

src/parser/xhpast/tests/data/php-nested-quotes.test

src/parser/xhpast/tests/data/php-short-array.php.expect

src/parser/xhpast/tests/data/php-short-array.php.test

src/parser/xhpast/tests/data/php-syntax.php.expect

src/parser/xhpast/tests/data/php-syntax.php.test

src/parser/xhpast/tests/data/php-tags.php.expect

src/parser/xhpast/tests/data/php-tags.php.test

src/parser/xhpast/tests/data/php-traits.php.expect

src/parser/xhpast/tests/data/php-traits.php.test

src/parser/xhpast/tests/data/php-yield.php.expect

src/parser/xhpast/tests/data/php-yield.php.test