Page MenuHomePhabricator

Extract some email address utility code from the receiver stack
ClosedPublic

Authored by epriestley on Jan 3 2019, 4:06 PM.

Details

Summary

Ref T7477. We have some address normalization code in the reciever stack that is really shared code. I want to introduce some new callsites elsewhere but don't want to put a lot of static calls to other random objects all over the place.

This technically "solves" T7477 (it changes "to" to "to + cc" for finding receivers) but doesn't yet implement proper behavior (with multiple receivers, for example).

Test Plan

Ran unit tests, which cover this pretty well. Additional changes will vet this more thoroughly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 3 2019, 4:06 PM
epriestley requested review of this revision.Jan 3 2019, 4:08 PM
amckinley accepted this revision.Jan 3 2019, 11:26 PM
This revision is now accepted and ready to land.Jan 3 2019, 11:26 PM
This revision was automatically updated to reflect the committed changes.