- --version exists with 1 (At least for 1.5.1)
- getLintCodeFromLinterConfigurationKey() was strangely used
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
run lint on some less code
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arcpatch-D14501
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 10181 Build 12361: Run Core Tests Build 12360: arc lint + arc unit
Event Timeline
Comment Actions
)
(This diff doesn't look very good; This is what git-show/git-diff looks like, and what I expected to see here:
and this is what I'm seeing here (with "ignore most whitespace":
)
Comment Actions
You can see that diff by selecting "Whitespace Changes: Show All" (and see it exactly by then switching to unified mode):
Comment Actions
Although it's a bit stripey, I think the whitespace-ignored diff is actually great -- it makes it very easy to see that you made exactly the expected changes. In the block version, it would be very hard to spot an accidental typo, like adding text in the middle of one of the strings or constants (say, a stray accidental keypress).
Comment Actions
Ok, at least that's consistent with git.
Mostly I was surprised that the whole message-> block is marked red/green, when it just moved around (No whitespace changes in it; The striped area was un-indented).
Comment Actions
--version exists with 1 (At least for 1.5.1)
Maybe leave a comment about this? I think the behavior is a little unusual, and I could imagine some well-intentioned contributor removing this in the future if lessc 2 no longer exhibits the behavior.
Rest of this looks good, except for the local lessc failure, which we should probably figure out.
Comment Actions
add comment about 1.5.1 exit code.
The unittest fail is, I think, because I was testing with 1.5.1 which is very old (2013-11), and just doesn't support
some features.
Running again with 2.5.3 (2015-09), the test passes.