Paths

Table of Contentst

Differential D14500

Improve test data format for XHPAST unit tests
ClosedPublic
Actions

Authored by joshuaspence on Nov 17 2015, 11:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 29, 1:49 PM

	Unknown Object (File)
	Wed, Apr 24, 10:16 PM

	Unknown Object (File)
	Sun, Apr 21, 3:51 PM

	Unknown Object (File)
	Wed, Apr 17, 2:01 PM

	Unknown Object (File)
	Tue, Apr 16, 12:40 PM

	Unknown Object (File)
	Mon, Apr 15, 11:56 PM

	Unknown Object (File)
	Mon, Apr 15, 11:56 PM

	Unknown Object (File)
	Mon, Apr 15, 11:54 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU12167cf6fb23: Improve test data format for XHPAST unit tests

Summary

Instead of having the input data and expected output stored in separate files, combine all data into a single file format similar to the *.lint-test format.

Test Plan

Ran unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8885
Build 10400: Run Core Tests
Build 10399: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35075.Nov 17 2015, 11:13 AM

joshuaspence retitled this revision from to Improve test data format for XHPAST unit tests.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 17 2015, 11:13 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Oh -- per D14498, these tests still kind of suck because they're almost unreadable. We'd only be slightly worse off by just hashing the tree, I think.

It would be nice to print them in some more human-readable format (mark up the input PHP file somehow to annotate tokens and the parse tree?) instead of dumping the raw JSON.

This revision is now accepted and ready to land.Nov 17 2015, 3:21 PM

Closed by commit rPHU12167cf6fb23: Improve test data format for XHPAST unit tests (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 18 2015, 8:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

PHPASTParserTestCase.php

39 lines

data/

base-fail-parse.php.expect

base-fail-parse.php.test

8 lines

base-fail-syntax.php.test

3 lines

base-pass.php.expect

base-pass.php.test

35 lines

namespace.php.expect

namespace.php.test

385 lines

php-access-on-instanciation-invalid.test

3 lines

php-access-on-instanciation.expect

php-access-on-instanciation.test

646 lines

php-array-dereference-2.expect

php-array-dereference-2.test

181 lines

php-array-dereference-3.expect

php-array-dereference-3.test

208 lines

php-array-dereference.expect

php-array-dereference.test

644 lines

php-binary-literal.php.expect

php-binary-literal.php.test

55 lines

php-callable-typehint.php.expect

php-callable-typehint.php.test

143 lines

php-class-expr.php.test

3 lines

php-comments.php.expect

php-comments.php.test

63 lines

php-empty-heredoc.php.expect

php-empty-heredoc.php.test

92 lines

php-finally.php.expect

php-finally.php.test

177 lines

php-foreach-list.php.test

3 lines

php-heredoc-terminal.php.expect

php-heredoc-terminal.php.test

51 lines

php-literal-index.php.expect

php-literal-index.php.test

163 lines

php-literals.php.expect

php-literals.php.test

355 lines

php-nested-quotes.test

3 lines

php-short-array.php.expect

php-short-array.php.test

70 lines

php-syntax.php.expect

php-syntax.php.test

11120 lines

php-tags.php.expect

php-tags.php.test

211 lines

php-traits.php.expect

php-traits.php.test

911 lines

php-yield.php.expect

php-yield.php.test

437 lines

Diff 35075

src/parser/xhpast/tests/PHPASTParserTestCase.php

Loading...

src/parser/xhpast/tests/data/base-fail-parse.php.expect

Loading...

src/parser/xhpast/tests/data/base-fail-parse.php.test

Loading...

src/parser/xhpast/tests/data/base-fail-syntax.php.test

Loading...

src/parser/xhpast/tests/data/base-pass.php.expect

Loading...

src/parser/xhpast/tests/data/base-pass.php.test

Loading...

src/parser/xhpast/tests/data/namespace.php.expect

Loading...

src/parser/xhpast/tests/data/namespace.php.test

Loading...

src/parser/xhpast/tests/data/php-access-on-instanciation-invalid.test

Loading...

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

Loading...

src/parser/xhpast/tests/data/php-access-on-instanciation.test

Loading...

src/parser/xhpast/tests/data/php-array-dereference-2.expect

Loading...

src/parser/xhpast/tests/data/php-array-dereference-2.test

Loading...

src/parser/xhpast/tests/data/php-array-dereference-3.expect

Loading...

src/parser/xhpast/tests/data/php-array-dereference-3.test

Loading...

src/parser/xhpast/tests/data/php-array-dereference.expect

Loading...

src/parser/xhpast/tests/data/php-array-dereference.test

Loading...

src/parser/xhpast/tests/data/php-binary-literal.php.expect

Loading...

src/parser/xhpast/tests/data/php-binary-literal.php.test

Loading...

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

Loading...

src/parser/xhpast/tests/data/php-callable-typehint.php.test

Loading...

src/parser/xhpast/tests/data/php-class-expr.php.test

Loading...

src/parser/xhpast/tests/data/php-comments.php.expect

Loading...

src/parser/xhpast/tests/data/php-comments.php.test

Loading...

src/parser/xhpast/tests/data/php-empty-heredoc.php.expect

Loading...

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

Loading...

src/parser/xhpast/tests/data/php-finally.php.expect

Loading...

src/parser/xhpast/tests/data/php-finally.php.test

Loading...

src/parser/xhpast/tests/data/php-foreach-list.php.test

Loading...

src/parser/xhpast/tests/data/php-heredoc-terminal.php.expect

Loading...

src/parser/xhpast/tests/data/php-heredoc-terminal.php.test

Loading...

src/parser/xhpast/tests/data/php-literal-index.php.expect

Loading...

src/parser/xhpast/tests/data/php-literal-index.php.test

Loading...

src/parser/xhpast/tests/data/php-literals.php.expect

Loading...

src/parser/xhpast/tests/data/php-literals.php.test

Loading...

src/parser/xhpast/tests/data/php-nested-quotes.test

Loading...

src/parser/xhpast/tests/data/php-short-array.php.expect

Loading...

src/parser/xhpast/tests/data/php-short-array.php.test

Loading...

src/parser/xhpast/tests/data/php-syntax.php.expect

Loading...

src/parser/xhpast/tests/data/php-syntax.php.test

Loading...

src/parser/xhpast/tests/data/php-tags.php.expect

Loading...

src/parser/xhpast/tests/data/php-tags.php.test

Loading...

src/parser/xhpast/tests/data/php-traits.php.expect

Loading...

src/parser/xhpast/tests/data/php-traits.php.test

Loading...

src/parser/xhpast/tests/data/php-yield.php.expect

Loading...

src/parser/xhpast/tests/data/php-yield.php.test

Loading...