Paths

Table of Contentst

Differential D14488

Add some additional unit tests
Changes PlannedPublic
Actions

Authored by joshuaspence on Nov 15 2015, 11:31 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

Add some additional test cases for ArcanistXHPASTLinterRule implementations and alo break down existing test cases into smaller test cases. Depends on D14010.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/lint/linter/xhpast/rules/__tests__/array-index-spacing/append.lint-test:7	TXT2	Tab Literal
Error	src/lint/linter/xhpast/rules/__tests__/array-index-spacing/index.lint-test:7	TXT2	Tab Literal
Warning	src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php:212	TXT3	Line Too Long

Unit

Test Failures

Build Status

Buildable 8883
Build 10396: Run Core Tests
Build 10395: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	184 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	37 ms	ArcanistPHPCloseTagXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	10 ms	ArcanistPHPCloseTagXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	372 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	18 ms	ArcanistRubyLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (7 Failed · 260 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35047.Nov 15 2015, 11:31 AM

joshuaspence retitled this revision from to Add some additional unit tests.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2015, 11:31 AM

Herald added a subscriber: Korvin. · View Herald Transcript

That build failure looks accurate, see inline.

I'm not really sure that it's valuable to split tests like the define() test apart? I feel like when a test breaks, I often need to look at both positive and negative test cases to fix it. This seems to spread relevant information out without providing an obvious benefit -- it's not like this is breaking 1000-line ultra-tests apart, just splitting tiny tests of the same code (which already produce tailored, relevant errors on failure) apart? That said, I don't have particularly strong feelings either way.

src/lint/linter/xhpast/rules/__tests__/dynamic-define/static.lint-test
4	Test failure on this seems correct?

This revision is now accepted and ready to land.Nov 15 2015, 4:29 PM

joshuaspence updated this object.Nov 16 2015, 12:03 PM

joshuaspence edited edge metadata.

joshuaspence added a parent revision: D14010: Test XHPAST linter rules in isolation.

Further progress

joshuaspence planned changes to this revision.Nov 17 2015, 10:26 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

xhpast/

ArcanistXHPASTLinterRule.php

2 lines

rules/

ArcanistArrayIndexSpacingXHPASTLinterRule.php

7 lines

ArcanistBlacklistedFunctionXHPASTLinterRule.php

12 lines

ArcanistCallTimePassByReferenceXHPASTLinterRule.php

5 lines

ArcanistCommentSpacingXHPASTLinterRule.php

4 lines

ArcanistCommentStyleXHPASTLinterRule.php

6 lines

ArcanistDynamicDefineXHPASTLinterRule.php

15 lines

ArcanistExtractUseXHPASTLinterRule.php

3 lines

ArcanistInnerFunctionXHPASTLinterRule.php

4 lines

ArcanistInvalidDefaultParameterXHPASTLinterRule.php

4 lines

ArcanistLambdaFuncFunctionXHPASTLinterRule.php

8 lines

ArcanistLogicalOperatorsXHPASTLinterRule.php

10 lines

ArcanistNamingConventionsXHPASTLinterRule.php

10 lines

ArcanistObjectOperatorSpacingXHPASTLinterRule.php

8 lines

ArcanistPHPCloseTagXHPASTLinterRule.php

8 lines

ArcanistPHPCompatibilityXHPASTLinterRule.php

6 lines

ArcanistPHPEchoTagXHPASTLinterRule.php

4 lines

ArcanistPHPShortTagXHPASTLinterRule.php

2 lines

ArcanistPregQuoteMisuseXHPASTLinterRule.php

29 lines

ArcanistRaggedClassTreeEdgeXHPASTLinterRule.php

23 lines

ArcanistReusedAsIteratorXHPASTLinterRule.php

2 lines

ArcanistToStringExceptionXHPASTLinterRule.php

9 lines

ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

2 lines

ArcanistUnnecessarySemicolonXHPASTLinterRule.php

14 lines

ArcanistUselessOverridingMethodXHPASTLinterRule.php

22 lines

__tests__/

ArcanistPHPCloseTagXHPASTLinterRuleTestCase.php

10 lines

ArcanistUnnecessarySemicolonXHPASTLinterRuleTestCase.php

10 lines

__lambda_func-function/

	__lambda_func.lint-test
	lamba-func-function.lint-test

3 lines

lamba-func-function.lint-test

__toString-exception/

__toString-exception.lint-test

abstract.lint-test

5 lines

case-insensitive.lint-test

8 lines

exception.lint-test

19 lines

interface.lint-test

5 lines

no-exception.lint-test

7 lines

array-index-spacing/

append.lint-test

19 lines

array-index-spacing.lint-test

index.lint-test

19 lines

blacklisted-function/

blacklisted-function.lint-test

	eval.lint-test
	blacklisted-function.lint-test

3 lines

call-time-pass-by-reference/

array.lint-test

3 lines

bitwise.lint-test

3 lines

call-time-pass-by-reference.lint-test

38 lines

function-declaration.lint-test

4 lines

use.lint-test

3 lines

cast-spacing/

cast-spacing.lint-test

6 lines

dynamic-define/

dynamic-define.lint-test

dynamic.lint-test

6 lines

static.lint-test

4 lines

extract-use/

extract-use.lint-test

	extract.lint-test
	extract-use.lint-test

3 lines

inner-function/

closure.lint-test

5 lines

inner-function.lint-test

14 lines

logical-operators/

boolean-operators.lint-test

4 lines

logical-operators.lint-test

16 lines

parse_str-use/

one-parameter.lint-test

4 lines

parse_str-use.lint-test

	two-parameters.lint-test
	parse_str-use.lint-test

3 lines

php-close-tag/

inline-html.lint-test

9 lines

	php-close-tag/
	extract-use/

	php.lint-test
	extract-use.lint-test

4 lines

preg_quote-misuse/

misuse.lint-test

6 lines

preg_quote-misuse.lint-test

use.lint-test

4 lines

ragged-classtree-edge/

abstract.lint-test

3 lines

concrete-extensible.lint-test

6 lines

final.lint-test

3 lines

ragged-classtree-edge.lint-test

12 lines

semicolon-spacing/

no-spacing.lint-test

5 lines

semicolon-spacing.lint-test

	spacing.lint-test
	semicolon-spacing.lint-test

11 lines

unnecessary-semicolon/

4 lines

9 lines

2 lines

4 lines

useless-overriding-method/

bypass.lint-test

11 lines

case-insensitive.lint-test

9 lines

constructor.lint-test

9 lines

default-value.lint-test

8 lines

dynamic.lint-test

8 lines

empty-method.lint-test

6 lines

matched-arguments.lint-test

14 lines

mismatched-arguments.lint-test

12 lines

no-arguments.lint-test

9 lines

pass-by-reference.lint-test

9 lines

useless-overriding-method.lint-test

variable-variable/

nonvariable.lint-test

4 lines

variable-variables.lint-test

variable.lint-test

7 lines

Add some additional unit testsChanges PlannedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 35073

src/__phutil_library_map__.php

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistArrayIndexSpacingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistBlacklistedFunctionXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistCallTimePassByReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistCommentSpacingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistCommentStyleXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistDynamicDefineXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistExtractUseXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistInnerFunctionXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistInvalidDefaultParameterXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistLambdaFuncFunctionXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistLogicalOperatorsXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistNamingConventionsXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistObjectOperatorSpacingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPHPCloseTagXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPHPEchoTagXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPHPShortTagXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPregQuoteMisuseXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistRaggedClassTreeEdgeXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistReusedAsIteratorXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistToStringExceptionXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistUnnecessaryFinalModifierXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistUnnecessarySemicolonXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistUselessOverridingMethodXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistPHPCloseTagXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistUnnecessarySemicolonXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/__lambda_func-function/__lambda_func.lint-test

src/lint/linter/xhpast/rules/__tests__/__lambda_func-function/lamba-func-function.lint-test

src/lint/linter/xhpast/rules/__tests__/__toString-exception/__toString-exception.lint-test

src/lint/linter/xhpast/rules/__tests__/__toString-exception/abstract.lint-test

src/lint/linter/xhpast/rules/__tests__/__toString-exception/case-insensitive.lint-test

src/lint/linter/xhpast/rules/__tests__/__toString-exception/exception.lint-test

src/lint/linter/xhpast/rules/__tests__/__toString-exception/interface.lint-test

src/lint/linter/xhpast/rules/__tests__/__toString-exception/no-exception.lint-test

src/lint/linter/xhpast/rules/__tests__/array-index-spacing/append.lint-test

src/lint/linter/xhpast/rules/__tests__/array-index-spacing/array-index-spacing.lint-test

src/lint/linter/xhpast/rules/__tests__/array-index-spacing/index.lint-test

src/lint/linter/xhpast/rules/__tests__/blacklisted-function/blacklisted-function.lint-test

src/lint/linter/xhpast/rules/__tests__/blacklisted-function/eval.lint-test

src/lint/linter/xhpast/rules/__tests__/call-time-pass-by-reference/array.lint-test

src/lint/linter/xhpast/rules/__tests__/call-time-pass-by-reference/bitwise.lint-test

src/lint/linter/xhpast/rules/__tests__/call-time-pass-by-reference/call-time-pass-by-reference.lint-test

src/lint/linter/xhpast/rules/__tests__/call-time-pass-by-reference/function-declaration.lint-test

src/lint/linter/xhpast/rules/__tests__/call-time-pass-by-reference/use.lint-test

src/lint/linter/xhpast/rules/__tests__/cast-spacing/cast-spacing.lint-test

src/lint/linter/xhpast/rules/__tests__/dynamic-define/dynamic-define.lint-test

src/lint/linter/xhpast/rules/__tests__/dynamic-define/dynamic.lint-test

src/lint/linter/xhpast/rules/__tests__/dynamic-define/static.lint-test

src/lint/linter/xhpast/rules/__tests__/extract-use/extract-use.lint-test

src/lint/linter/xhpast/rules/__tests__/extract-use/extract.lint-test

src/lint/linter/xhpast/rules/__tests__/inner-function/closure.lint-test

src/lint/linter/xhpast/rules/__tests__/inner-function/inner-function.lint-test

src/lint/linter/xhpast/rules/__tests__/logical-operators/boolean-operators.lint-test

src/lint/linter/xhpast/rules/__tests__/logical-operators/logical-operators.lint-test

src/lint/linter/xhpast/rules/__tests__/parse_str-use/one-parameter.lint-test

src/lint/linter/xhpast/rules/__tests__/parse_str-use/parse_str-use.lint-test

src/lint/linter/xhpast/rules/__tests__/parse_str-use/two-parameters.lint-test

src/lint/linter/xhpast/rules/__tests__/php-close-tag/inline-html.lint-test

src/lint/linter/xhpast/rules/__tests__/php-close-tag/php.lint-test

src/lint/linter/xhpast/rules/__tests__/preg_quote-misuse/misuse.lint-test

src/lint/linter/xhpast/rules/__tests__/preg_quote-misuse/preg_quote-misuse.lint-test

src/lint/linter/xhpast/rules/__tests__/preg_quote-misuse/use.lint-test

src/lint/linter/xhpast/rules/__tests__/ragged-classtree-edge/abstract.lint-test

src/lint/linter/xhpast/rules/__tests__/ragged-classtree-edge/concrete-extensible.lint-test

src/lint/linter/xhpast/rules/__tests__/ragged-classtree-edge/final.lint-test

src/lint/linter/xhpast/rules/__tests__/ragged-classtree-edge/ragged-classtree-edge.lint-test

src/lint/linter/xhpast/rules/__tests__/semicolon-spacing/no-spacing.lint-test

src/lint/linter/xhpast/rules/__tests__/semicolon-spacing/semicolon-spacing.lint-test

src/lint/linter/xhpast/rules/__tests__/semicolon-spacing/spacing.lint-test

src/lint/linter/xhpast/rules/__tests__/unnecessary-semicolon/class.lint-test

src/lint/linter/xhpast/rules/__tests__/unnecessary-semicolon/declare.lint-test

Add some additional unit tests
Changes PlannedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List

src/lint/linter/xhpast/rules/tests/ArcanistPHPCloseTagXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistUnnecessarySemicolonXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/__lambda_func-function/__lambda_func.lint-test

src/lint/linter/xhpast/rules/tests/__lambda_func-function/lamba-func-function.lint-test

src/lint/linter/xhpast/rules/tests/toString-exception/toString-exception.lint-test

src/lint/linter/xhpast/rules/tests/__toString-exception/abstract.lint-test

src/lint/linter/xhpast/rules/tests/__toString-exception/case-insensitive.lint-test

src/lint/linter/xhpast/rules/tests/__toString-exception/exception.lint-test

src/lint/linter/xhpast/rules/tests/__toString-exception/interface.lint-test

src/lint/linter/xhpast/rules/tests/__toString-exception/no-exception.lint-test

src/lint/linter/xhpast/rules/tests/array-index-spacing/append.lint-test

src/lint/linter/xhpast/rules/tests/array-index-spacing/array-index-spacing.lint-test

src/lint/linter/xhpast/rules/tests/array-index-spacing/index.lint-test

src/lint/linter/xhpast/rules/tests/blacklisted-function/blacklisted-function.lint-test

src/lint/linter/xhpast/rules/tests/blacklisted-function/eval.lint-test

src/lint/linter/xhpast/rules/tests/call-time-pass-by-reference/array.lint-test

src/lint/linter/xhpast/rules/tests/call-time-pass-by-reference/bitwise.lint-test

src/lint/linter/xhpast/rules/tests/call-time-pass-by-reference/call-time-pass-by-reference.lint-test

src/lint/linter/xhpast/rules/tests/call-time-pass-by-reference/function-declaration.lint-test

src/lint/linter/xhpast/rules/tests/call-time-pass-by-reference/use.lint-test

src/lint/linter/xhpast/rules/tests/cast-spacing/cast-spacing.lint-test

src/lint/linter/xhpast/rules/tests/dynamic-define/dynamic-define.lint-test

src/lint/linter/xhpast/rules/tests/dynamic-define/dynamic.lint-test

src/lint/linter/xhpast/rules/tests/dynamic-define/static.lint-test

src/lint/linter/xhpast/rules/tests/extract-use/extract-use.lint-test

src/lint/linter/xhpast/rules/tests/extract-use/extract.lint-test

src/lint/linter/xhpast/rules/tests/inner-function/closure.lint-test

src/lint/linter/xhpast/rules/tests/inner-function/inner-function.lint-test

src/lint/linter/xhpast/rules/tests/logical-operators/boolean-operators.lint-test

src/lint/linter/xhpast/rules/tests/logical-operators/logical-operators.lint-test

src/lint/linter/xhpast/rules/tests/parse_str-use/one-parameter.lint-test

src/lint/linter/xhpast/rules/tests/parse_str-use/parse_str-use.lint-test

src/lint/linter/xhpast/rules/tests/parse_str-use/two-parameters.lint-test

src/lint/linter/xhpast/rules/tests/php-close-tag/inline-html.lint-test

src/lint/linter/xhpast/rules/tests/php-close-tag/php.lint-test

src/lint/linter/xhpast/rules/tests/preg_quote-misuse/misuse.lint-test

src/lint/linter/xhpast/rules/tests/preg_quote-misuse/preg_quote-misuse.lint-test

src/lint/linter/xhpast/rules/tests/preg_quote-misuse/use.lint-test

src/lint/linter/xhpast/rules/tests/ragged-classtree-edge/abstract.lint-test

src/lint/linter/xhpast/rules/tests/ragged-classtree-edge/concrete-extensible.lint-test

src/lint/linter/xhpast/rules/tests/ragged-classtree-edge/final.lint-test

src/lint/linter/xhpast/rules/tests/ragged-classtree-edge/ragged-classtree-edge.lint-test

src/lint/linter/xhpast/rules/tests/semicolon-spacing/no-spacing.lint-test

src/lint/linter/xhpast/rules/tests/semicolon-spacing/semicolon-spacing.lint-test

src/lint/linter/xhpast/rules/tests/semicolon-spacing/spacing.lint-test

src/lint/linter/xhpast/rules/tests/unnecessary-semicolon/class.lint-test

src/lint/linter/xhpast/rules/tests/unnecessary-semicolon/declare.lint-test

src/lint/linter/xhpast/rules/tests/unnecessary-semicolon/empty.lint-test

src/lint/linter/xhpast/rules/tests/unnecessary-semicolon/statement.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/bypass.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/case-insensitive.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/constructor.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/default-value.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/dynamic.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/empty-method.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/matched-arguments.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/mismatched-arguments.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/no-arguments.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/pass-by-reference.lint-test

src/lint/linter/xhpast/rules/tests/useless-overriding-method/useless-overriding-method.lint-test

src/lint/linter/xhpast/rules/tests/variable-variable/nonvariable.lint-test

src/lint/linter/xhpast/rules/tests/variable-variable/variable-variables.lint-test

src/lint/linter/xhpast/rules/tests/variable-variable/variable.lint-test