Page MenuHomePhabricator

Allow lint messages to be rendered as Remarkup
ClosedPublic

Authored by joshuaspence on Nov 15 2015, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 9, 9:16 PM
Unknown Object (File)
Tue, Aug 9, 11:02 AM
Unknown Object (File)
Tue, Aug 2, 4:40 AM
Unknown Object (File)
Fri, Jul 29, 1:25 AM
Unknown Object (File)
Fri, Jul 29, 12:45 AM
Unknown Object (File)
Fri, Jul 15, 10:03 PM
Unknown Object (File)
Thu, Jul 14, 8:41 AM
Unknown Object (File)
Jul 5 2022, 3:23 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP1f1c3f40755e: Allow lint messages to be rendered as Remarkup
Summary

Some linter messages, such as those produced by ArcanistPHPCompatibilityXHPASTLinterRule, contain backticks but are currently rendered as Remarkup literals. I think that it is generally desirable to allow lint messages to be rendered as Remarkup, although we should ideally have a way to render Remarkup for use on the command line (I actually think that this already exists, but I don't think that arc lint does this when rendering linter messages).

Test Plan

Resubmitted D14481 to my dev install and saw Remarkuped lint messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Allow lint messages to be rendered as Remarkup.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
joshuaspence updated this object.
epriestley edited edge metadata.

Yeah, this was some Facebook jank.

src/applications/differential/controller/DifferentialChangesetViewController.php
389–390

I will boldly claim that this line can be completely removed without disastrous effect.

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
266–271

In modern code, I am generally not aligning stuff anymore. It looks a little nicer to align, but causes a lot of churn that I'm leaning toward not being worthwhile. Consider 'string'<single space>=><single space>value in lieu of alignment.

This revision is now accepted and ready to land.Nov 15 2015, 4:31 PM
joshuaspence edited edge metadata.
  • Remove useless assignment
  • Unalign
This revision was automatically updated to reflect the committed changes.