Some linter messages, such as those produced by ArcanistPHPCompatibilityXHPASTLinterRule, contain backticks but are currently rendered as Remarkup literals. I think that it is generally desirable to allow lint messages to be rendered as Remarkup, although we should ideally have a way to render Remarkup for use on the command line (I actually think that this already exists, but I don't think that arc lint does this when rendering linter messages).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP1f1c3f40755e: Allow lint messages to be rendered as Remarkup
Resubmitted D14481 to my dev install and saw Remarkuped lint messages.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8843 Build 10326: Run Core Tests Build 10325: arc lint + arc unit
Event Timeline
Comment Actions
Yeah, this was some Facebook jank.
| src/applications/differential/controller/DifferentialChangesetViewController.php | ||
|---|---|---|
| 390 | I will boldly claim that this line can be completely removed without disastrous effect. | |
| src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php | ||
| 267–271 | In modern code, I am generally not aligning stuff anymore. It looks a little nicer to align, but causes a lot of churn that I'm leaning toward not being worthwhile. Consider 'string'<single space>=><single space>value in lieu of alignment. | |