Page MenuHomePhabricator

Start working on making callsigns optional
AbandonedPublic

Authored by joshuaspence on Nov 14 2015, 10:38 AM.
Tags
None
Referenced Files
F14395297: D14483.diff
Sun, Dec 22, 4:04 AM
Unknown Object (File)
Sat, Dec 21, 12:56 AM
Unknown Object (File)
Sun, Dec 15, 12:11 AM
Unknown Object (File)
Fri, Dec 13, 3:52 AM
Unknown Object (File)
Thu, Dec 12, 10:29 AM
Unknown Object (File)
Mon, Dec 9, 10:01 PM
Unknown Object (File)
Sat, Nov 30, 2:13 PM
Unknown Object (File)
Nov 21 2024, 11:54 AM

Details

Summary

Ref T4245. This is very rough.

Test Plan

WIP

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8835
Build 10315: Run Core Tests
Build 10314: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Start working on making callsigns optional.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)

I'd like to take some smaller steps forward here first. Particularly, I want to make "Clone As" an optional unique identifier, and allow that to be used in place of the callsign or ID in reasonable contexts. We should do that first so we can do both ID and "clone as" at the same time when making URI changes. Some steps forward might include:

  • Convert as many calls to getCallsign() into getMonogram() (or getURI()?) as possible.
  • Make cloneAs unique and migrate existing values to enforce uniqueness.
    • Must not be all uppercase (i.e., unambiguous with CALLSIGN).
    • Must not be all digits (i.e., unambiguous with ID).
    • Allowable characters are a-z, 0-9, hyphen, underscore? Maybe forbid leading or trailing hyphen or underscore?

Then do something in this vein, accommodating both ID and the new slug-names rather than just IDs.

epriestley added a reviewer: epriestley.

Broadly fine, I'd just like to sequence it after clone name changes.

This revision now requires changes to proceed.Nov 15 2015, 4:39 PM

This should be obsolete at HEAD, yeah.