Page MenuHomePhabricator

Refactor ArcanistUnitWorkflow to take after ArcanistLintWorkflow
Needs RevisionPublic

Authored by lucaspickup on Nov 12 2015, 5:42 AM.
Tags
None
Referenced Files
F14026581: D14466.diff
Fri, Nov 8, 1:41 AM
Unknown Object (File)
Oct 1 2024, 3:16 PM
Unknown Object (File)
Sep 24 2024, 7:24 PM
Unknown Object (File)
Sep 12 2024, 8:12 AM
Unknown Object (File)
Sep 10 2024, 2:31 AM
Unknown Object (File)
Sep 5 2024, 5:10 PM
Unknown Object (File)
Sep 4 2024, 9:45 AM
Unknown Object (File)
Sep 2 2024, 11:04 AM
Subscribers
This revision can not be accepted until the required legal agreements have been signed.

Details

Summary

This diff is motivated by these two tickets: T4949, T4950.

With the goal of having JUnit formatted test results and Clover formatted coverage results in mind there were preliminary steps to take.
The ArcanistLintWorkflow uses renderers seemed like the best way to approach rendering the output in the desired formats and the way
it dealt with specifying an outfile seemed like the best way to get our output into a file usuable in a CI environment.

So to use the ArcanistLintWorkflow approach I needed to refactor ArcanistUnitWorkflow to kind of work the same.

This will lead into diffs for supporting outfiles and the extra renderers for our desired output.

The main difference is soem code reshuffling and moving the json and ugly rendering methods into actual renderers and removing the
redundant command line arguments.

Test Plan

Tried all the different output formats with arc unit --output and made sure it output the same as before the changes.
arc unit also operates the same.
the code that deals with coverage was only 'moved' and not modified.

Diff Detail

Repository
rARC Arcanist
Branch
ArcanistUnitRefactor
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8796
Build 10252: arc lint + arc unit

Event Timeline

lucaspickup retitled this revision from to Refactor ArcanistUnitWorkflow to take after ArcanistLintWorkflow.
lucaspickup updated this object.
lucaspickup edited the test plan for this revision. (Show Details)
lucaspickup added a reviewer: joshuaspence.
epriestley added a reviewer: epriestley.

Needs CLA (see L28 / L30).

This revision now requires changes to proceed.Nov 23 2015, 4:20 PM

Content Hidden

The content of this revision is hidden until the author has signed all of the required legal agreements.