Page MenuHomePhabricator

Add a linter rule for `parent` references
ClosedPublic

Authored by joshuaspence on Nov 9 2015, 12:59 AM.
Tags
None
Referenced Files
F13142872: D14443.diff
Fri, May 3, 6:53 AM
Unknown Object (File)
Thu, Apr 25, 1:18 AM
Unknown Object (File)
Mon, Apr 22, 7:03 PM
Unknown Object (File)
Mon, Apr 8, 10:07 AM
Unknown Object (File)
Fri, Apr 5, 6:14 PM
Unknown Object (File)
Fri, Apr 5, 10:44 AM
Unknown Object (File)
Mar 29 2024, 1:24 PM
Unknown Object (File)
Mar 20 2024, 3:30 AM
Subscribers

Details

Summary

Add a linter rule to detect static method calls which should reference the parent class instead of a hardcoded class reference. For example, consider the following:

class SomeClass extends AnotherClass {
  public function someMethod() {
    AnotherClass::someOtherMethod();
  }
}

This should instead be written as:

class SomeClass extends AnotherClass {
  public function someMethod() {
    parent::someOtherMethod();
  }
}
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8817
Build 10286: Run Core Tests
Build 10285: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for `parent` references.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.
epriestley added inline comments.
src/lint/linter/xhpast/rules/ArcanistParentMemberReferenceXHPASTLinterRule.php
63

Extra period in human-readable message.

This revision is now accepted and ready to land.Nov 15 2015, 4:52 PM
joshuaspence edited edge metadata.

Fix lint message

This revision was automatically updated to reflect the committed changes.