Page MenuHomePhabricator
Differential D14416

Make all comments quotable
AbandonedPublic
Actions

Authored by joshuaspence on Nov 5 2015, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 5:43 AM
Unknown Object (File)
Thu, May 2, 6:48 AM
Unknown Object (File)
Sun, Apr 28, 5:53 AM
Unknown Object (File)
Thu, Apr 25, 12:56 AM
Unknown Object (File)
Fri, Apr 19, 2:22 AM
Unknown Object (File)
Fri, Apr 19, 2:22 AM
Unknown Object (File)
Fri, Apr 19, 2:22 AM
Unknown Object (File)
Thu, Apr 11, 8:42 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9077: Some applications don't support the "Quote" action on comments properly
Summary

Fixes T9077. This is a bit messy at the moment and I'm happy to do some tidying up / refactoring, but it seems to work.

Test Plan

Quoted comments in all affected applications.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 8636
Build 9998: Run Core Tests
Build 9997: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34826.Nov 5 2015, 8:09 PM
joshuaspence retitled this revision from to Make all comments quotable.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T9077: Some applications don't support the "Quote" action on comments properly.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 5 2015, 8:09 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley edited edge metadata.Nov 5 2015, 8:28 PM

For the refs, maybe just let the code render a neutral string if no ref is present? e.g.

(With Ref) In Txxx#qqqq, epriestley wrote:
(Without Ref) Previously, epriestley wrote:

We lose the link to the comment, but that seems like a small loss for badges/macros.

src/applications/paste/controller/PhabricatorPasteViewController.php
70

First half of this could be monogram, too.

joshuaspence updated this revision to Diff 34837.Nov 6 2015, 2:29 AM
joshuaspence edited edge metadata.

More applications

epriestley requested changes to this revision.Nov 8 2015, 2:24 PM
epriestley edited edge metadata.

WIP

This revision now requires changes to proceed.Nov 8 2015, 2:24 PM
epriestley mentioned this in T9077: Some applications don't support the "Quote" action on comments properly.Dec 5 2015, 9:26 PM
joshuaspence abandoned this revision.May 17 2019, 1:13 AM

Not actively working on this.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
controller/
3 lines
countdown/
controller/
3 lines
files/
controller/
3 lines
legalpad/
controller/
3 lines
macro/
controller/
3 lines
paste/
controller/
5 lines
slowvote/
controller/
3 lines
transactions/
view/
2 lines

Diff 34826

View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentManageController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
Phabricator · Built by Phacility