Paths

Table of Contentst

Differential D14378

Add some missing translations
ClosedPublic
Actions

Authored by joshuaspence on Nov 2 2015, 10:28 AM.

Tags

None

Referenced Files

	F14494642: D14378.diff
	Fri, Jan 3, 6:06 AM

	Unknown Object (File)
	Wed, Dec 25, 5:13 PM

	Unknown Object (File)
	Fri, Dec 13, 11:41 AM

	Unknown Object (File)
	Thu, Dec 12, 7:25 PM

	Unknown Object (File)
	Fri, Dec 6, 7:57 PM

	Unknown Object (File)
	Nov 20 2024, 6:26 PM

	Unknown Object (File)
	Nov 16 2024, 3:46 PM

	Unknown Object (File)
	Nov 12 2024, 5:10 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU2826ef3c683b: Add some missing translations

Summary

Add some missing translations from D14071.

Test Plan

I'm actually not sure where these are meant to go... we don't seem to store any translations in rPHU.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8546
Build 9863: Run Core Tests
Build 9862: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34722.Nov 2 2015, 10:28 AM

joshuaspence retitled this revision from to Add some missing translations.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 2 2015, 10:28 AM

Herald added a subscriber: Korvin. · View Herald Transcript

These should go in libphutil/, we just haven't translated anything there yet. Just add a similar translation file, like the ones in Arcanist and Phabricator.

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1435–1436 ↗	(On Diff #34722)	Consider spelling out the singular cases, "Analyzing 1 file with 1 subprocess..." is still more stilted in English than, e.g., "Analyzing one file with a single subprocess..."
1445 ↗	(On Diff #34722)	Missing closing parenthesis.

This revision is now accepted and ready to land.Nov 2 2015, 1:02 PM

Move to rPHU
Fix missing parentheses

Closed by commit rPHU2826ef3c683b: Add some missing translations (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 2 2015, 7:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

__phutil_library_map__.php

2 lines

-

-

internationalization/

translation/

LibphutilUSEnglishTranslation.php

34 lines

0%

Loading...

Diff 34736

src/__phutil_library_map__.php

Loading...

src/internationalization/translation/LibphutilUSEnglishTranslation.php

Loading...