Page MenuHomePhabricator

Move "Next Step" to a custom field in Differential
ClosedPublic

Authored by epriestley on Oct 30 2015, 2:47 PM.

Details

Summary

Fixes T9672. This was never turned into a custom field, for no particular reason. Convert it into one.

This is substantially similar to the existing "Apply Patch" field, which does the same thing (only shows a command).

We might rethink or remove this eventually (e.g., in a post-"Land Revision" world) but this makes it easier, at the very least.

Test Plan
  • Viewed a non-accepted revision (no hint).
  • Viewed an accepted revision from a raw diff source (no hint).
  • Viewed an accepted revision from Git (arc land hint).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Move "Next Step" to a custom field in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2015, 3:55 PM
This revision was automatically updated to reflect the committed changes.