In PHUIInfoView, only show list UI if more than 1 item
ClosedPublic
Actions

Authored by chad on Oct 19 2015, 11:24 PM.

Tags

None

Referenced Files

	F13999966: D14308.diff
	Thu, Oct 24, 6:20 PM

	F13985674: D14308.diff
	Sun, Oct 20, 10:17 PM

	F13981011: D14308.id34540.diff
	Oct 19 2024, 1:48 PM

	F13960000: D14308.id34537.diff
	Oct 14 2024, 9:36 PM

	Unknown Object (File)
	Sep 30 2024, 2:53 PM

	Unknown Object (File)
	Sep 5 2024, 10:41 PM

	Unknown Object (File)
	Sep 1 2024, 1:37 PM

	Unknown Object (File)
	Aug 27 2024, 8:20 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPbbbda23678dd: In PHUIInfoView, only show list UI if more than 1 item

Summary

We often just setError as an array even if it's only one error. This just makes the UI a little cleaner in these cases.

Test Plan

Remove all reviewers from a diff, see status error without list styling.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34537.Oct 19 2015, 11:24 PM

chad retitled this revision from to In PHUIInfoView, only show list UI if more than 1 item.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 19 2015, 11:24 PM

epriestley accepted this revision.Oct 20 2015, 2:12 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 20 2015, 2:12 AM

Closed by commit rPbbbda23678dd: In PHUIInfoView, only show list UI if more than 1 item (authored by chad, committed by chad). · Explain WhyOct 20 2015, 3:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

PHUIInfoView.php

4 lines

Diff 34540

View Options

src/view/form/PHUIInfoView.php

In PHUIInfoView, only show list UI if more than 1 itemClosedPublicActions