Page MenuHomePhabricator
Differential D14300

Fix fatal in Maniphest
ClosedPublic
Actions

Authored by vlada on Oct 18 2015, 7:55 PM.
Tags
None
Referenced Files
F12198383: D14300.diff
Fri, Sep 29, 6:11 AM
F12167665: D14300.diff
Thu, Sep 7, 3:10 AM
F12146184: D14300.diff
Fri, Sep 1, 1:07 AM
F12145207: D14300.diff
Thu, Aug 31, 5:17 PM
F12136872: D14300.id34516.diff
Aug 26 2023, 12:30 PM
Unknown Object (File)
Aug 8 2023, 6:33 AM
Unknown Object (File)
Jul 21 2023, 4:17 PM
Unknown Object (File)
Jul 17 2023, 3:23 AM
View All Files
Subscribers
avivey
Korvin
tycho.tatitscheff

Details

Reviewers
tycho.tatitscheff
epriestley
avivey
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9596: Call to undefined method PhabricatorActionListView::setDisabled()
Commits
Restricted Diffusion Commit
rP478249147006: Fix fatal in Maniphest
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Fixes T9596.

Was unable to navigate to a task in Maniphest.

Test Plan

navigate to that task.

Diff Detail

Repository
rP Phabricator
Branch
taskdetailbug
Lint
Lint Skipped
Unit
Test Failures
Build Status
Buildable 8330
Build 9552: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
1,744 msManiphestTaskTestCase::Unknown Unit Message ("")
957 msManiphestTaskTestCase::Unknown Unit Message ("")
1,425 msPhabricatorLibraryTestCase::Unknown Unit Message ("")
1,249 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
70 msPhabricatorConduitTestCase::Unknown Unit Message ("")
View Full Test Results (3 Failed · 6 Passed)

Event Timeline

vlada updated this revision to Diff 34516.Oct 18 2015, 7:55 PM
vlada retitled this revision from to Fix fatal in Maniphest.
vlada updated this object.
vlada edited the test plan for this revision. (Show Details)
vlada added a reviewer: epriestley.
vlada added a task: T9596: Call to undefined method PhabricatorActionListView::setDisabled().
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 18 2015, 7:55 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: Korvin. · View Herald Transcript
vlada added a comment.Oct 18 2015, 7:56 PM

Looks like it was caused by D14299?

avivey accepted this revision.Oct 18 2015, 8:18 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

I've ran units on my system.

(Are you also running this on RPi? that shouldn't work.)

tycho.tatitscheff accepted this revision.Oct 18 2015, 9:04 PM
tycho.tatitscheff added a reviewer: tycho.tatitscheff.
tycho.tatitscheff added a subscriber: tycho.tatitscheff.

Yes my bad ! I was going to submit the same fix.
Y made a typo when amending changes to correct the indent on linting.

Closed by commit rP478249147006: Fix fatal in Maniphest (authored by chad, committed by chad). · Explain WhyOct 18 2015, 9:43 PM
This revision was automatically updated to reflect the committed changes.
vlada added a comment.Oct 18 2015, 10:12 PM

@avivey, yeah, I've got a Phabricator setup running on a Raspberry Pi2 for some personal projects. I've just done it today, it's got a very basic setup, and it's rather slow, but it works. So far, I'm happy.

$ arc lint on the actual Phabricator repository didn't work though, I was trying to compile xhpast and ran into a missing gcc flag.

epriestley edited edge metadata.Oct 19 2015, 1:02 AM

Thanks! Sorry about this.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
4 lines

Diff 34516

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
Phabricator · Built by Phacility