Page MenuHomePhabricator
Differential D14242

Improve consistency and Harbormaster integration of Diffusion
ClosedPublic
Actions

Authored by epriestley on Oct 6 2015, 1:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:15 AM
Unknown Object (File)
Mon, Dec 16, 5:40 PM
Unknown Object (File)
Fri, Dec 13, 10:37 AM
Unknown Object (File)
Sat, Dec 7, 6:42 AM
Unknown Object (File)
Sat, Nov 30, 9:06 AM
Unknown Object (File)
Thu, Nov 28, 1:09 AM
Unknown Object (File)
Tue, Nov 26, 8:07 PM
Unknown Object (File)
Fri, Nov 22, 12:49 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9123: Build Phabricator in Harbormaster (v2)
Commits
Restricted Diffusion Commit
rP2bfa0e087e00: Improve consistency and Harbormaster integration of Diffusion
Summary

Ref T9123. Two major Harbormaster-related UI changes in Diffusion:

  • Tags table now shows tag build status.
  • Branches table now shows branch build status.

Then some minor consistency / qualtiy of life changes:

  • Picked a nicer looking "history" icon?
  • Branches table now uses the same "history" icon as other tables.
  • Tags table now has a "history" link.
  • Browse table now has a "history" link.
  • Dates now use more consistent formatting.
  • Column order is now more consistent.
  • Use of style is now more consistent.
Test Plan

Screen Shot 2015-10-06 at 5.58.55 AM.png (200×1 px, 47 KB)

Screen Shot 2015-10-06 at 5.58.48 AM.png (134×1 px, 23 KB)

Screen Shot 2015-10-06 at 5.59.00 AM.png (568×1 px, 157 KB)

Diff Detail

Repository
rP Phabricator
Branch
diffui1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8199
Build 9375: Run Core Tests
Build 9374: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34387.Oct 6 2015, 1:02 PM
epriestley retitled this revision from to Improve consistency and Harbormaster integration of Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9123: Build Phabricator in Harbormaster (v2).
epriestley updated this object.Oct 6 2015, 1:03 PM
chad accepted this revision.Oct 6 2015, 1:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2015, 1:50 PM
Closed by commit rP2bfa0e087e00: Improve consistency and Harbormaster integration of Diffusion (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2015, 2:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34387

View Options

src/applications/diffusion/controller/DiffusionLastModifiedController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBranchTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionTagListView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionView.php

Loading...
Phabricator · Built by Phacility