Page MenuHomePhabricator
Differential D14165

Improve validation of 'name' and 'code' parameters for lint messages
ClosedPublic
Actions

Authored by epriestley on Sep 25 2015, 5:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:01 AM
Unknown Object (File)
Wed, Dec 11, 10:33 PM
Unknown Object (File)
Tue, Dec 10, 7:03 PM
Unknown Object (File)
Mon, Dec 9, 7:01 PM
Unknown Object (File)
Sun, Dec 8, 10:52 AM
Unknown Object (File)
Wed, Dec 4, 11:48 AM
Unknown Object (File)
Sat, Nov 30, 2:09 PM
Unknown Object (File)
Tue, Nov 26, 11:08 AM
View All Files
Subscribers
aik099

Details

Reviewers
chad
Maniphest Tasks
T9145: Exception on arc diff with PHPCS linter
T9316: Linters must include Name fields
Commits
rARCac28f951d69c: (stable) Promote 2015 Week 39
rARCe8a0ebaeffaa: Improve validation of 'name' and 'code' parameters for lint messages
Summary

Ref T9145. Fixes T9316. We now require "name" and "code" has a maximum length (currently, this is 32, but the next diff will raise it to 128).

Test Plan
  • Installed PHPCS.
  • Hit both the "name" and "code" issues.
  • Applied this patch.
  • Got better errors sooner.

Diff Detail

Repository
rARC Arcanist
Branch
lintname
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8056
Build 9146: [Placeholder Plan] Wait for 30 Seconds
Build 9145: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34222.Sep 25 2015, 5:02 PM
epriestley retitled this revision from to Improve validation of 'name' and 'code' parameters for lint messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T9316: Linters must include Name fields, T9145: Exception on arc diff with PHPCS linter.
epriestley mentioned this in T9316: Linters must include Name fields.Sep 25 2015, 5:05 PM
aik099 added a subscriber: aik099.Sep 25 2015, 5:15 PM
chad accepted this revision.Sep 25 2015, 6:11 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 6:11 PM
Closed by commit rARCe8a0ebaeffaa: Improve validation of 'name' and 'code' parameters for lint messages (authored by epriestley, committed by epriestley). · Explain WhySep 25 2015, 6:16 PM
This revision was automatically updated to reflect the committed changes.
tedkornish mentioned this in D14182: Add a name to Golang ArcanistLintMessages.Sep 28 2015, 10:00 PM
vm mentioned this in D14225: Set name on more linters.Oct 2 2015, 3:57 PM
epriestley mentioned this in rARC1b4a3e0c5eb9: Set path on more linters.Oct 2 2015, 3:58 PM
dereckson mentioned this in D11657: Add a ShellCheck linter.Mar 14 2017, 12:01 PM
epriestley mentioned this in T12981: Explicitly limit lint and unit test names to 255 characters.Sep 12 2017, 7:08 PM

Revision Contents
Changeset List

PathSize
src/
lint/
17 lines
engine/
15 lines
linter/
20 lines

Diff 34222

View Options

src/lint/ArcanistLintMessage.php

Loading...
View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistPhpcsLinter.php

Loading...
Phabricator · Built by Phacility