Page MenuHomePhabricator

Improve validation of 'name' and 'code' parameters for lint messages
ClosedPublic

Authored by epriestley on Sep 25 2015, 5:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 4:41 PM
Unknown Object (File)
Fri, Mar 15, 4:11 PM
Unknown Object (File)
Fri, Mar 15, 3:07 PM
Unknown Object (File)
Fri, Mar 15, 2:11 PM
Unknown Object (File)
Thu, Mar 14, 6:48 PM
Unknown Object (File)
Thu, Mar 14, 4:15 PM
Unknown Object (File)
Tue, Mar 12, 5:02 PM
Unknown Object (File)
Tue, Mar 12, 3:50 PM
Subscribers

Details

Summary

Ref T9145. Fixes T9316. We now require "name" and "code" has a maximum length (currently, this is 32, but the next diff will raise it to 128).

Test Plan
  • Installed PHPCS.
  • Hit both the "name" and "code" issues.
  • Applied this patch.
  • Got better errors sooner.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve validation of 'name' and 'code' parameters for lint messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 6:11 PM
This revision was automatically updated to reflect the committed changes.