Page MenuHomePhabricator

Add a name to Golang ArcanistLintMessages
AbandonedPublic

Authored by tedkornish on Sep 28 2015, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 3:29 AM
Unknown Object (File)
Thu, Apr 11, 10:21 AM
Unknown Object (File)
Mar 17 2024, 8:41 PM
Unknown Object (File)
Mar 17 2024, 8:29 PM
Unknown Object (File)
Mar 17 2024, 6:42 PM
Unknown Object (File)
Mar 15 2024, 4:25 PM
Unknown Object (File)
Mar 4 2024, 6:17 PM
Unknown Object (File)
Mar 4 2024, 4:31 PM
Subscribers

Details

Summary

It looks like D14165 broke a few of the linters included with Arcanist because those linters weren't setting names on their lint messages, thus failing the validation. This revision adds a name to Go lint messages - I just picked something static, but I'm more than open to suggestions on better names for errors!

epriestly, I'm adding you as the reviewer because you were the one who diffed up D14165.

Test Plan

Using arcanist on this revision, configure a project to use the Go linter and create a public type without a comment. golint should squawk because there's no comment and it should get parsed out properly into a lint error.

Diff Detail

Repository
rARC Arcanist
Branch
fix-golint-error
Lint
Lint Skipped
Unit
Test Failures
Build Status
Buildable 8077
Build 9186: [Placeholder Plan] Wait for 30 Seconds
Build 9185: arc lint + arc unit

Event Timeline

tedkornish retitled this revision from to Add a name to Golang ArcanistLintMessages.
tedkornish updated this object.
tedkornish edited the test plan for this revision. (Show Details)
tedkornish added a reviewer: epriestley.
tedkornish added a subscriber: chad.

Looks like this got fixed in a different revision. Thanks!

awwyiss