Page MenuHomePhabricator

Improve validation of 'name' and 'code' parameters for lint messages
ClosedPublic

Authored by epriestley on Sep 25 2015, 5:02 PM.
Tags
None
Referenced Files
F17947715: D14165.id.diff
Thu, Jul 31, 6:08 PM
F17943474: D14165.diff
Thu, Jul 31, 8:24 AM
F17925697: D14165.diff
Wed, Jul 30, 11:56 AM
Unknown Object (File)
Jul 1 2025, 9:18 PM
Unknown Object (File)
Jun 29 2025, 11:00 AM
Unknown Object (File)
May 29 2025, 4:31 PM
Unknown Object (File)
May 28 2025, 11:46 AM
Unknown Object (File)
May 8 2025, 5:26 AM
Subscribers

Details

Summary

Ref T9145. Fixes T9316. We now require "name" and "code" has a maximum length (currently, this is 32, but the next diff will raise it to 128).

Test Plan
  • Installed PHPCS.
  • Hit both the "name" and "code" issues.
  • Applied this patch.
  • Got better errors sooner.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve validation of 'name' and 'code' parameters for lint messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 6:11 PM
This revision was automatically updated to reflect the committed changes.