Differential D14072

Various translation improvements
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2015, 6:12 AM.

Tags

None

Referenced Files

	F18086367: D14072.id34723.diff
	Tue, Aug 5, 9:28 PM

	F18086366: D14072.id34012.diff
	Tue, Aug 5, 9:28 PM

	F18086365: D14072.id.diff
	Tue, Aug 5, 9:28 PM

	F18085176: D14072.id.diff
	Tue, Aug 5, 7:02 PM

	F18083857: D14072.diff
	Tue, Aug 5, 11:49 AM

	F18078638: D14072.diff
	Mon, Aug 4, 8:18 PM

	F17676722: D14072.id34012.diff
	Sun, Jul 13, 10:12 AM

	Unknown Object (File)
	Jun 26 2025, 9:16 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCebb88c8c59a4: (stable) Promote 2015 Week 45
rARC2db40f995337: Various translation improvements

Summary

Depends on D14070.

Test Plan

Eyeball it.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7929
Build 8887: [Placeholder Plan] Wait for 30 Seconds
Build 8886: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	8 ms	PhpunitTestEngineTestCase::Unknown Unit Message ("")
	39 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
	15 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
	45 ms	ArcanistLibraryTestCase::Unknown Unit Message ("")
	0 ms	ArcanistUnitTestResultTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 9 Passed)

Event Timeline

joshuaspence updated this revision to Diff 34012.Sep 6 2015, 6:12 AM

joshuaspence retitled this revision from to Various translation improvements.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D14070: Add a `phutil_count` function.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2015, 6:12 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Sep 6 2015, 3:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 6 2015, 3:04 PM

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Minor fixes

Closed by commit rARC2db40f995337: Various translation improvements (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 2 2015, 10:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

internationalization/

ArcanistUSEnglishTranslation.php

10 lines

unit/

engine/

phutil/

PhutilTestCase.php

5 lines

upload/

ArcanistFileUploader.php

6 lines

workflow/

ArcanistCommitWorkflow.php

6 lines

ArcanistCoverWorkflow.php

2 lines

ArcanistDiffWorkflow.php

10 lines

ArcanistUploadWorkflow.php

6 lines

ArcanistWorkflow.php

12 lines

Diff 34012

src/internationalization/ArcanistUSEnglishTranslation.php

Loading...

src/unit/engine/phutil/PhutilTestCase.php

Loading...

src/upload/ArcanistFileUploader.php

Loading...

src/workflow/ArcanistCommitWorkflow.php

Loading...

src/workflow/ArcanistCoverWorkflow.php

Loading...

src/workflow/ArcanistDiffWorkflow.php

Loading...

src/workflow/ArcanistUploadWorkflow.php

Loading...

src/workflow/ArcanistWorkflow.php

Loading...