Page MenuHomePhabricator
Differential D14054

Shuffle various parts of the config edit UI around
ClosedPublic
Actions

Authored by epriestley on Sep 3 2015, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 5:59 PM
Unknown Object (File)
Wed, Dec 11, 5:47 PM
Unknown Object (File)
Sat, Dec 7, 4:02 PM
Unknown Object (File)
Fri, Nov 29, 11:48 PM
Unknown Object (File)
Thu, Nov 28, 6:52 PM
Unknown Object (File)
Nov 18 2024, 7:19 PM
Unknown Object (File)
Nov 14 2024, 9:30 PM
Unknown Object (File)
Nov 8 2024, 8:37 PM
View All Files
Subscribers
avivey

Details

Reviewers
avivey
chad
Maniphest Tasks
T9339: Config Edit "Value" field is confusing
Commits
Restricted Diffusion Commit
rPcd2f9786bf8e: Shuffle various parts of the config edit UI around
Summary

Fixes T9339.

  • Don't show edit control for locked config at all.
  • Don't show a "Cancel" button either.
  • Change "Value" label to "Database Value" for non-custom config.
  • Highlight effective value.
  • Move examples under current state.
  • Tweak some formatting.
Test Plan

Screen Shot 2015-09-03 at 11.57.48 AM.png (884×1 px, 168 KB)

Diff Detail

Repository
rP Phabricator
Branch
configui
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 7908
Build 8845: [Placeholder Plan] Wait for 30 Seconds
Build 8844: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
112 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
8 msPhabricatorConduitTestCase::Unknown Unit Message ("")
0 msPhabricatorInfrastructureTestCase::Unknown Unit Message ("")
1 msPhabricatorInfrastructureTestCase::Unknown Unit Message ("")
609 msPhabricatorLibraryTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 6 Passed)

Event Timeline

epriestley updated this revision to Diff 33980.Sep 3 2015, 7:06 PM
epriestley retitled this revision from to Shuffle various parts of the config edit UI around.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9339: Config Edit "Value" field is confusing.
Herald edited edge metadata. · View Herald TranscriptSep 3 2015, 7:06 PM
epriestley updated this revision to Diff 33981.Sep 3 2015, 7:07 PM
epriestley edited edge metadata.
  • Whoops.
Herald edited edge metadata. · View Herald TranscriptSep 3 2015, 7:07 PM
epriestley added a comment.Sep 3 2015, 7:07 PM

Oh, and "(empty)" -> "(No Value Configured)" and "Default" -> "Current Configuration".

chad accepted this revision.Sep 3 2015, 7:08 PM
chad edited edge metadata.

itsbeautiful

This revision is now accepted and ready to land.Sep 3 2015, 7:08 PM
avivey accepted this revision.Sep 3 2015, 7:11 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

lgtm

Closed by commit rPcd2f9786bf8e: Shuffle various parts of the config edit UI around (authored by epriestley, committed by epriestley). · Explain WhySep 3 2015, 7:15 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
config/
controller/
55 lines
option/
6 lines
webroot/
rsrc/
css/
application/
config/
5 lines

Diff 33980

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/option/PhabricatorConfigOption.php

Loading...
View Options

webroot/rsrc/css/application/config/config-options.css

Loading...
Phabricator · Built by Phacility