Page MenuHomePhabricator

Fix mail parameter error with old migrations

Authored by epriestley on Aug 24 2015, 4:30 PM.



Fixes T9251. Old mail could get saved with bad parameters for two reasons that I can come up with:

  • Nothing ever set a parameter on it -- not sure this could ever actually happen; or
  • some field contained non-UTF8 data prior to D13939 and we silently failed to encode it.

My guess is that the second case is probably the culprit here.

In any case, recover from this so can proceed.

Test Plan

Same effective patch as user patch in T9251; looked at some mail to make sure it was still pulling parameters properly.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix mail parameter error with old migrations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.