Page MenuHomePhabricator

Fix mail parameter error with old migrations
ClosedPublic

Authored by epriestley on Aug 24 2015, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 3:47 AM
Unknown Object (File)
Sun, Mar 17, 6:57 AM
Unknown Object (File)
Tue, Mar 5, 10:11 AM
Unknown Object (File)
Feb 18 2024, 1:11 PM
Unknown Object (File)
Jan 28 2024, 5:36 PM
Unknown Object (File)
Jan 28 2024, 5:36 PM
Unknown Object (File)
Jan 27 2024, 5:32 AM
Unknown Object (File)
Jan 25 2024, 2:30 PM
Subscribers
None

Details

Summary

Fixes T9251. Old mail could get saved with bad parameters for two reasons that I can come up with:

  • Nothing ever set a parameter on it -- not sure this could ever actually happen; or
  • some field contained non-UTF8 data prior to D13939 and we silently failed to encode it.

My guess is that the second case is probably the culprit here.

In any case, recover from this so 20150622.metamta.5.actor-phid-mig.php can proceed.

Test Plan

Same effective patch as user patch in T9251; looked at some mail to make sure it was still pulling parameters properly.

Diff Detail

Repository
rP Phabricator
Branch
mail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7804
Build 8640: [Placeholder Plan] Wait for 30 Seconds
Build 8639: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix mail parameter error with old migrations.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.