Use didRejectResult() when querying workboard columns
ClosedPublic
Actions

Authored by epriestley on Aug 23 2015, 2:23 PM.

Details

Reviewers

joshuaspence
chad

Maniphest Tasks

T4345: Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)"
T9250: "Unknown Object" shown when an object is moved on a workboard that cannot be seen

Commits

Restricted Diffusion Commit
rP9e3f3e692d7f: Use didRejectResult() when querying workboard columns

Summary

Fixes T9250. Ref T4345.

Test Plan

Faked a policy error:

Diff Detail

Repository

rP Phabricator

Branch

reject1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7743
Build 8519: [Placeholder Plan] Wait for 30 Seconds
Build 8518: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33722.Aug 23 2015, 2:23 PM

epriestley retitled this revision from to Use didRejectResult() when querying workboard columns.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, joshuaspence.

epriestley added tasks: T9250: "Unknown Object" shown when an object is moved on a workboard that cannot be seen, T4345: Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)".

chad accepted this revision.Aug 23 2015, 3:06 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 23 2015, 3:06 PM

Closed by commit rP9e3f3e692d7f: Use didRejectResult() when querying workboard columns (authored by epriestley, committed by epriestley). · Explain WhyAug 23 2015, 3:31 PM

This revision was automatically updated to reflect the committed changes.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectColumnQuery.php

40 lines

Diff 33722

View Options

src/applications/project/query/PhabricatorProjectColumnQuery.php

Use didRejectResult() when querying workboard columnsClosedPublicActions