Paths

Table of Contentst

Differential D13976

Remove unused replacestr function from XHPAST
ClosedPublic
Actions

Authored by joshuaspence on Aug 23 2015, 8:23 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUff71c34f3e8f: Remove unused replacestr function from XHPAST

Summary

This method is unused after D1319.

Test Plan

grep

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7738
Build 8509: [Placeholder Plan] Wait for 30 Seconds
Build 8508: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33716.Aug 23 2015, 8:23 AM

joshuaspence retitled this revision from to Remove unused replacestr function from XHPAST.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 8:23 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 23 2015, 2:08 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 23 2015, 2:08 PM

Closed by commit rPHUff71c34f3e8f: Remove unused replacestr function from XHPAST (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 23 2015, 9:15 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in rPHU2a099c8296ff: Update generated parser files.Aug 24 2015, 11:13 AM

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

support/

xhpast/

parser.y

12 lines

parser.yacc.cpp

1568 lines

Diff 33716

View Options

support/xhpast/parser.y