Yeah, I think we need the per macro option of rendering as original. This also feels to small for me as a default. Macros should be cool.

Does this solve some of T5258

I don't think it does; I didn't change how the meme image is generated (I just added an additional step to transform the transformed image).

What's the actual problem that this is trying to solve?

It's something like "it would be more convenient if you didn't have to open Photoshop to resize a macro", right? Not "all macros should have a standard size" or "users upload macros that are too big" or whatever?

If the file upload dialog had some simple image editing options (e.g., for v0, a UI to resize and maybe crop images) that would completely solve this problem in a more general and flexible way and obsolete this change, right?

I feel as though destroying the original uploaded image by resizing or cropping them on upload is probably undesirable; there have been times when I've uploaded images to services, resized them and then a while later needed the original resolution which I no longer have.

Substantially this is no different to the way that {F1234} syntax works in that it thumbnails embedded images; this just does the same for macros and memes so that they aren't ridiculous sizes on people's screens.

We could add a size=full option to the {meme} markup to allow people to use the original size, but I think most people just want sensible defaults here. When I upload a non-macro image, it gets resized for me inline (thumbnail with a link to original size); when I upload a macro image, it doesn't get resized. Moving the work from a desktop tool to having to pick a sensible macro size that will work on all layout forms (mobile, desktop, email) ahead of time seems less desirable than just allowing Phabricator to make the smart decision of how big something should be for usual meme consumption.

In D13933#152781, @hach-que wrote:

I feel as though destroying the original uploaded image by resizing or cropping them on upload is probably undesirable; there have been times when I've uploaded images to services, resized them and then a while later needed the original resolution which I no longer have.

Substantially this is no different to the way that {F1234} syntax works in that it thumbnails embedded images; this just does the same for macros and memes so that they aren't ridiculous sizes on people's screens.

We could add a size=full option to the {meme} markup to allow people to use the original size, but I think most people just want sensible defaults here. When I upload a non-macro image, it gets resized for me inline (thumbnail with a link to original size); when I upload a macro image, it doesn't get resized. Moving the work from a desktop tool to having to pick a sensible macro size that will work on all layout forms (mobile, desktop, email) ahead of time seems less desirable than just allowing Phabricator to make the smart decision of how big something should be for usual meme consumption.

+1