Flesh out web UI for mail a bit to prepare for Herald outbound rules
ClosedPublic
Actions

Authored by epriestley on Aug 12 2015, 4:03 PM.

Details

Reviewers

Maniphest Tasks

T5791: Write Herald rules for outbound mail
T7013: Support bulk transmission of notification frames in internal Aphlict protocol
T9141: Rename "MetaMTA" to "Mail"

Commits

Restricted Diffusion Commit
rP8c06d89070b9: Flesh out web UI for mail a bit to prepare for Herald outbound rules

Summary

Ref T9141. Ref T5791. Ref T7013. Major changes here is:

Currently, we don't store the headers we actually sent, or the reasons we actually did or did not deliver a mail.
- Start storing these (as headers.sent and actors.sent).
- Show them in the web UI.
- Show them in bin/mail show-outbound (previously, we sort of re-computed them in a hacky way).
- Take them into account in bin/mail volume.

Then some minor changes:

Show mail bodies.
Show more mail information.
Start renaming "MetaMTA" to "Mail", at least in the web UI.

Test Plan

Screen Shot 2015-08-12 at 8.47.36 AM.png (268×427 px, 27 KB)

Screen Shot 2015-08-12 at 8.34.23 AM.png (897×1 px, 136 KB)

Screen Shot 2015-08-12 at 8.34.28 AM.png (897×1 px, 124 KB)

Screen Shot 2015-08-12 at 8.34.27 AM.png (897×1 px, 134 KB)

Screen Shot 2015-08-12 at 8.34.25 AM.png (897×1 px, 195 KB)

Diff Detail

Repository

rP Phabricator

Branch

hmail1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php:171	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 7606
Build 8252: [Placeholder Plan] Wait for 30 Seconds
Build 8251: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33509.Aug 12 2015, 4:03 PM

epriestley retitled this revision from to Flesh out web UI for mail a bit to prepare for Herald outbound rules.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9141: Rename "MetaMTA" to "Mail", T7013: Support bulk transmission of notification frames in internal Aphlict protocol, T5791: Write Herald rules for outbound mail.

epriestley mentioned this in T7013: Support bulk transmission of notification frames in internal Aphlict protocol.Aug 12 2015, 4:23 PM

You can setStacked on PHUIPropertyListView on some of these, then your key won't get cut off. Also D13568 should help make these more readable / responsive as well.

chad accepted this revision.Aug 12 2015, 6:33 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 12 2015, 6:33 PM