Page MenuHomePhabricator

Widen PHUIPropertyListView when ActionList isn't attached
ClosedPublic

Authored by chad on Jul 7 2015, 2:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 2:45 AM
Unknown Object (File)
Tue, Dec 10, 6:54 PM
Unknown Object (File)
Sun, Dec 8, 4:34 PM
Unknown Object (File)
Sat, Dec 7, 1:49 AM
Unknown Object (File)
Thu, Dec 5, 5:16 PM
Unknown Object (File)
Mon, Dec 2, 1:14 AM
Unknown Object (File)
Fri, Nov 29, 1:24 PM
Unknown Object (File)
Fri, Nov 29, 1:24 PM
Subscribers

Details

Summary

This makes PHUIPropertyList display wider when an ActionList isn't present.

Test Plan

Review Diff Details in a Diff. Test mobile and desktop layouts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Widen Diff Detail property list.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.

I anticipate bringing an action list down into this property list (with "Update Diff" and "Download Raw Diff") to shrink the total header size at little. Does that make sense?

Is that the only reason to bring them down? I guess my concern is the table itself is already space constrained. I'm also not terribly a fan of multiple action lists on a page. Maybe just be header buttons? Is that weird? Design something custom?

I wonder if we can move 'errors' to being their own PropertyListSection. So if everything passes, no extra sections, but if it fails its summarized in the PropertyList and then explained in detail below in its own section. That would be me freedom to design the right table/layout and be much more readable.

chad retitled this revision from Widen Diff Detail property list to Widen PHUIPropertyListView when ActionList isn't attached.Aug 12 2015, 6:26 PM
chad edited edge metadata.

I'd still like to land this since it's universally usable.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2015, 6:14 PM

I'm still getting the lint error on src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:21

oh derp, maybe I should rebase

This revision was automatically updated to reflect the committed changes.