This makes PHUIPropertyList display wider when an ActionList isn't present.
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rP526aa48f8b48: Widen PHUIPropertyListView when ActionList isn't attached
Review Diff Details in a Diff. Test mobile and desktop layouts.
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I anticipate bringing an action list down into this property list (with "Update Diff" and "Download Raw Diff") to shrink the total header size at little. Does that make sense?
Is that the only reason to bring them down? I guess my concern is the table itself is already space constrained. I'm also not terribly a fan of multiple action lists on a page. Maybe just be header buttons? Is that weird? Design something custom?
I wonder if we can move 'errors' to being their own PropertyListSection. So if everything passes, no extra sections, but if it fails its summarized in the PropertyList and then explained in detail below in its own section. That would be me freedom to design the right table/layout and be much more readable.
I'm still getting the lint error on src/applications/conpherence/query/ConpherenceThreadSearchEngine.php:21