Page MenuHomePhabricator

Flesh out web UI for mail a bit to prepare for Herald outbound rules
ClosedPublic

Authored by epriestley on Aug 12 2015, 4:03 PM.

Details

Summary

Ref T9141. Ref T5791. Ref T7013. Major changes here is:

  • Currently, we don't store the headers we actually sent, or the reasons we actually did or did not deliver a mail.
    • Start storing these (as headers.sent and actors.sent).
    • Show them in the web UI.
    • Show them in bin/mail show-outbound (previously, we sort of re-computed them in a hacky way).
    • Take them into account in bin/mail volume.

Then some minor changes:

  • Show mail bodies.
  • Show more mail information.
  • Start renaming "MetaMTA" to "Mail", at least in the web UI.
Test Plan





Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 33509.Aug 12 2015, 4:03 PM
epriestley retitled this revision from to Flesh out web UI for mail a bit to prepare for Herald outbound rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.Aug 12 2015, 6:33 PM

You can setStacked on PHUIPropertyListView on some of these, then your key won't get cut off. Also D13568 should help make these more readable / responsive as well.

chad accepted this revision.Aug 12 2015, 6:33 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 12 2015, 6:33 PM
epriestley updated this revision to Diff 33511.Aug 12 2015, 6:53 PM
epriestley edited edge metadata.
  • Stack the headers, which can have arbitrarily long names.
This revision was automatically updated to reflect the committed changes.