Paths

Table of Contentst

Differential D13799

Add Subscribers to Passphrase
ClosedPublic
Actions

Authored by chad on Aug 5 2015, 6:55 PM.

Tags

None

Referenced Files

	F14061129: D13799.diff
	Mon, Nov 18, 5:19 AM

	F14047818: D13799.diff
	Thu, Nov 14, 5:24 AM

	F14043031: D13799.id33326.diff
	Tue, Nov 12, 7:22 AM

	F14039498: D13799.id33327.diff
	Mon, Nov 11, 5:48 AM

	F14039493: D13799.id33325.diff
	Mon, Nov 11, 5:47 AM

	F14039490: D13799.diff
	Mon, Nov 11, 5:46 AM

	F14034276: D13799.diff
	Sat, Nov 9, 11:24 PM

	F14023728: D13799.id33327.diff
	Thu, Nov 7, 3:44 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T9078: Allow Passphrase credentials to be subscribbable

Commits

Restricted Diffusion Commit
rPb34dc6164af2: Add Subscribers to Passphrase

Summary

Fixes T9078, Adds SubscribableInterface to Passphrase.

Test Plan

Create a new passphrase, see myself subscribed. Subscribe to other Passphrases.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33325.Aug 5 2015, 6:55 PM

chad retitled this revision from to Add Subscribers to Passphrase.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9078: Allow Passphrase credentials to be subscribbable.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 5 2015, 6:55 PM

epriestley added inline comments.Aug 5 2015, 6:56 PM

src/applications/passphrase/storage/PassphraseCredential.php
156	Maybe omit this (just `return false;`) because we don't give the author any other special privileges for these object types. In particular, if you're in charge of Twitter and move to the Devops team, it's reasonable to revoke your access to a Twitter credential even if you created it. It seems correct to sever the author from the credential completely at this point.

epriestley accepted this revision.Aug 5 2015, 6:56 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 5 2015, 6:56 PM

Twitter team gots no chill

Closed by commit rPb34dc6164af2: Add Subscribers to Passphrase (authored by chad, committed by chad). · Explain WhyAug 5 2015, 6:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

1 line

applications/

passphrase/

controller/

PassphraseCredentialViewController.php

2 lines

storage/

PassphraseCredential.php

18 lines

Diff 33327

src/__phutil_library_map__.php

Loading...

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...

src/applications/passphrase/storage/PassphraseCredential.php

Loading...