Page MenuHomePhabricator
Differential D13778

Fix 'key'/'type' swap in email reset / one-time-login controller
ClosedPublic
Actions

Authored by epriestley on Aug 3 2015, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 6, 11:37 PM
Unknown Object (File)
Thu, Sep 5, 3:19 PM
Unknown Object (File)
Thu, Sep 5, 3:19 PM
Unknown Object (File)
Thu, Sep 5, 3:19 PM
Unknown Object (File)
Mon, Sep 2, 2:01 AM
Unknown Object (File)
Sat, Aug 31, 12:36 PM
Unknown Object (File)
Sun, Aug 25, 4:54 AM
Unknown Object (File)
Mon, Aug 19, 1:19 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
chad
Maniphest Tasks
T9046: "Forgot password" functionality is broken
Commits
Restricted Diffusion Commit
rPb4b5d60f77fb: Fix 'key'/'type' swap in email reset / one-time-login controller
Summary

Fixes T9046. These got swapped around during refactoring.

Test Plan
  • Used bin/auth recover prior to patch (failed).
  • Used bin/auth recover after patch (worked).

Diff Detail

Repository
rP Phabricator
Branch
linktype
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7472
Build 7984: [Placeholder Plan] Wait for 30 Seconds
Build 7983: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33273.Aug 3 2015, 1:06 PM
epriestley retitled this revision from to Fix 'key'/'type' swap in email reset / one-time-login controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
epriestley added a task: T9046: "Forgot password" functionality is broken.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 3 2015, 1:06 PM
chad accepted this revision.Aug 3 2015, 1:41 PM
chad edited edge metadata.

Ugh sorry

This revision is now accepted and ready to land.Aug 3 2015, 1:41 PM
epriestley added a comment.Aug 3 2015, 1:58 PM

No worries, your error rate on these has been crazy low so far. I think the biggest goof here was me not reproing properly in T9038, I'm just out of it and repro'd against stable instead of master and failed to make the connection.

Closed by commit rPb4b5d60f77fb: Fix 'key'/'type' swap in email reset / one-time-login controller (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 3:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
4 lines

Diff 33273

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

Loading...
Phabricator · Built by Phacility