Page MenuHomePhabricator

Fix 'key'/'type' swap in email reset / one-time-login controller
ClosedPublic

Authored by epriestley on Aug 3 2015, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 7:19 PM
Unknown Object (File)
Fri, Apr 12, 7:19 PM
Unknown Object (File)
Fri, Apr 12, 7:06 PM
Unknown Object (File)
Fri, Apr 12, 6:38 PM
Unknown Object (File)
Tue, Apr 9, 11:24 AM
Unknown Object (File)
Mon, Apr 1, 12:11 AM
Unknown Object (File)
Sun, Mar 31, 7:49 PM
Unknown Object (File)
Sat, Mar 16, 6:47 AM
Subscribers

Details

Summary

Fixes T9046. These got swapped around during refactoring.

Test Plan
  • Used bin/auth recover prior to patch (failed).
  • Used bin/auth recover after patch (worked).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix 'key'/'type' swap in email reset / one-time-login controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
chad edited edge metadata.

Ugh sorry

This revision is now accepted and ready to land.Aug 3 2015, 1:41 PM

No worries, your error rate on these has been crazy low so far. I think the biggest goof here was me not reproing properly in T9038, I'm just out of it and repro'd against stable instead of master and failed to make the connection.

This revision was automatically updated to reflect the committed changes.