one-time-login controller
ClosedPublic
Actions

Authored by epriestley on Aug 3 2015, 1:06 PM.

Details

Reviewers

joshuaspence
chad

Maniphest Tasks

T9046: "Forgot password" functionality is broken

Commits

Restricted Diffusion Commit
rPb4b5d60f77fb: Fix 'key'/'type' swap in email reset / one-time-login controller

Summary

Fixes T9046. These got swapped around during refactoring.

Test Plan

Used bin/auth recover prior to patch (failed).
Used bin/auth recover after patch (worked).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33273.Aug 3 2015, 1:06 PM

epriestley retitled this revision from to Fix 'key'/'type' swap in email reset / one-time-login controller.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, joshuaspence.

epriestley added a task: T9046: "Forgot password" functionality is broken.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 3 2015, 1:06 PM

Ugh sorry

This revision is now accepted and ready to land.Aug 3 2015, 1:41 PM

No worries, your error rate on these has been crazy low so far. I think the biggest goof here was me not reproing properly in T9038, I'm just out of it and repro'd against stable instead of master and failed to make the connection.

Closed by commit rPb4b5d60f77fb: Fix 'key'/'type' swap in email reset / one-time-login controller (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 3:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorAuthOneTimeLoginController.php

4 lines

Diff 33275

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

Fix 'key'/'type' swap in email reset / one-time-login controllerClosedPublicActions