Differential D13775

Update Settings for handleRequest
ClosedPublic
Actions

Authored by chad on Aug 2 2015, 12:23 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

Restricted Diffusion Commit
rPba2cc4f2eecf: Update Settings for handleRequest

Summary

Run through the Settings controllers

Test Plan

Test various settings pages, save some settings.

Diff Detail

Repository

rP Phabricator

Branch

settings-process

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7469
Build 7978: [Placeholder Plan] Wait for 30 Seconds
Build 7977: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33268.Aug 2 2015, 12:23 AM

chad retitled this revision from to Update Settings for handleRequest.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 2 2015, 12:23 AM

epriestley accepted this revision.Aug 4 2015, 4:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 4 2015, 4:31 PM

Closed by commit rPba2cc4f2eecf: Update Settings for handleRequest (authored by chad, committed by chad). · Explain WhyAug 4 2015, 4:32 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a task: T8628: Modernize AphrontControllers to implement handleRequest.Oct 18 2015, 6:51 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

controller/

PhabricatorSettingsAdjustController.php

3 lines

PhabricatorSettingsMainController.php

22 lines

Diff 33268

View Options

src/applications/settings/controller/PhabricatorSettingsAdjustController.php