Page MenuHomePhabricator
Differential D13701

Modularize "Send an Email" Herald actions
ClosedPublic
Actions

Authored by epriestley on Jul 24 2015, 3:37 PM.
Tags
None
Referenced Files
F17631127: D13701.diff
Thu, Jul 10, 12:39 PM
Unknown Object (File)
Thu, Jul 3, 1:58 PM
Unknown Object (File)
Wed, Jul 2, 10:35 PM
Unknown Object (File)
May 25 2025, 2:02 PM
Unknown Object (File)
May 20 2025, 10:49 PM
Unknown Object (File)
May 19 2025, 4:13 AM
Unknown Object (File)
Apr 24 2025, 9:41 PM
Unknown Object (File)
Apr 21 2025, 1:23 AM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP51fead17cf13: Modularize "Send an Email" Herald actions
Summary

Ref T8726. No surprises.

Test Plan

Created rules using both action variants, applied upgrade, saw rules still work correctly.

Screen Shot 2015-07-24 at 8.32.28 AM.png (152×544 px, 22 KB)

Diff Detail

Repository
rP Phabricator
Branch
heraldx5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7378
Build 7796: [Placeholder Plan] Wait for 30 Seconds
Build 7795: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33113.Jul 24 2015, 3:37 PM
epriestley retitled this revision from to Modularize "Send an Email" Herald actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2015, 3:37 PM
btrahan accepted this revision.Jul 24 2015, 5:42 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2015, 5:42 PM
btrahan added inline comments.Jul 24 2015, 5:42 PM
src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php
15–22

nice

joshuaspence added a subscriber: joshuaspence.Jul 25 2015, 11:26 PM
Closed by commit rP51fead17cf13: Modularize "Send an Email" Herald actions (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33113

View Options

resources/sql/autopatches/20150724.herald.2.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/maniphest/herald/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/metamta/herald/PhabricatorMetaMTAEmailHeraldAction.php

Loading...
View Options

src/applications/metamta/herald/PhabricatorMetaMTAEmailOthersHeraldAction.php

Loading...
View Options

src/applications/metamta/herald/PhabricatorMetaMTAEmailSelfHeraldAction.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSelfHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsAddSubscribersHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSelfHeraldAction.php

Loading...
View Options

src/applications/subscriptions/herald/PhabricatorSubscriptionsRemoveSubscribersHeraldAction.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility