Page MenuHomePhabricator
Differential D13595

Minor performance optimization
ClosedPublic
Actions

Authored by joshuaspence on Jul 8 2015, 7:29 AM.
Tags
None
Referenced Files
F15430047: D13595.diff
Mon, Mar 24, 5:28 AM
F15428011: D13595.id.diff
Sun, Mar 23, 5:39 PM
F15416314: D13595.id32853.diff
Thu, Mar 20, 10:29 AM
Unknown Object (File)
Feb 21 2025, 6:25 AM
Unknown Object (File)
Feb 20 2025, 2:26 PM
Unknown Object (File)
Feb 15 2025, 11:27 PM
Unknown Object (File)
Feb 9 2025, 3:58 AM
Unknown Object (File)
Feb 8 2025, 8:46 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC23a653e2bbad: Minor performance optimization
Summary

Avoid using idx in PhutilTestCase::endCoverage.

Test Plan

Compared before and after.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 32853.Jul 8 2015, 7:29 AM
joshuaspence retitled this revision from to Minor performance optimization.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2015, 7:29 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jul 8 2015, 7:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2015, 7:32 AM
Closed by commit rARC23a653e2bbad: Minor performance optimization (authored by joshuaspence, committed by joshuaspence). · Explain WhyJul 8 2015, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
unit/
engine/
phutil/
5 lines

Diff 32856

View Options

src/unit/engine/phutil/PhutilTestCase.php

Loading...
Phabricator · Built by Phacility