Page MenuHomePhabricator

Remove verbose output from `arc lint --trace`
ClosedPublic

Authored by joshuaspence on Jul 8 2015, 6:57 AM.
Tags
None
Referenced Files
F13159262: D13593.diff
Mon, May 6, 12:50 AM
Unknown Object (File)
Mon, Apr 29, 4:25 PM
Unknown Object (File)
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Fri, Apr 19, 10:20 AM
Unknown Object (File)
Thu, Apr 18, 3:46 AM
Unknown Object (File)
Thu, Apr 11, 8:21 AM
Unknown Object (File)
Apr 2 2024, 11:27 PM
Unknown Object (File)
Mar 31 2024, 6:24 AM
Subscribers

Details

Summary

I think that this output was used during the early stage of ArcanistConfigurationDrivenLintEngine, but I question it's value nowadays. In particular, I find that this output makes the output of arc lint --trace significantly less useful.

Test Plan

Ran ./bin/arc lint --trace and saw useful output.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7199
Build 7442: [Placeholder Plan] Wait for 30 Seconds
Build 7441: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Remove verbose output from `arc lint --trace`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I expected that users might find these include/exclude rules difficult to understand/debug, but I haven't actually seen any issues. It's vaguely possible that I haven't seen issues because we have this diagnostic output, but I'd expect most users having trouble to not make it as far as --trace, so I think this is probably low value / find to remove.

This revision is now accepted and ready to land.Jul 8 2015, 7:20 AM
This revision was automatically updated to reflect the committed changes.