Page MenuHomePhabricator

Remove verbose output from `arc lint --trace`
ClosedPublic

Authored by joshuaspence on Jul 8 2015, 6:57 AM.
Tags
None
Referenced Files
F15468590: D13593.diff
Fri, Apr 4, 2:43 AM
F15464204: D13593.id.diff
Wed, Apr 2, 7:16 AM
F15404737: D13593.id32850.diff
Tue, Mar 18, 8:48 AM
F15337262: D13593.id32864.diff
Sun, Mar 9, 5:01 AM
F15298851: D13593.diff
Wed, Mar 5, 1:50 PM
Unknown Object (File)
Feb 16 2025, 11:17 AM
Unknown Object (File)
Feb 11 2025, 12:02 PM
Unknown Object (File)
Feb 8 2025, 8:41 PM
Subscribers

Details

Summary

I think that this output was used during the early stage of ArcanistConfigurationDrivenLintEngine, but I question it's value nowadays. In particular, I find that this output makes the output of arc lint --trace significantly less useful.

Test Plan

Ran ./bin/arc lint --trace and saw useful output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Remove verbose output from `arc lint --trace`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I expected that users might find these include/exclude rules difficult to understand/debug, but I haven't actually seen any issues. It's vaguely possible that I haven't seen issues because we have this diagnostic output, but I'd expect most users having trouble to not make it as far as --trace, so I think this is probably low value / find to remove.

This revision is now accepted and ready to land.Jul 8 2015, 7:20 AM
This revision was automatically updated to reflect the committed changes.